Headers & sub-headers are inconsistently anchored and bolded - #98826
Headers & sub-headers are inconsistently anchored and bolded#98826dukenv0307 wants to merge 2 commits into
Conversation
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Lines 462 to 463 in f822c07
When browser navigation changes the URL from a section hash back to the same page without a hash, this early return leaves the previous selected-article class in place. This can occur after following a normal same-page anchor and then pressing Back, causing the LHN to keep bolding a section that is no longer represented by the URL; clear the active link before returning when the hash is empty.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Explanation of Change
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/671786
PROPOSAL:
Tests
Anchor that header or sub-header at the top of the page
Highlight/bold the sub-header in the LHN
Verify that no errors appear in the JS console
Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-18.at.00.18.39.mov