Skip to content

Move Recently added to right column and remove Announcements from Home - #98780

Open
adamgrzybowski wants to merge 5 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/reorganize-home
Open

Move Recently added to right column and remove Announcements from Home#98780
adamgrzybowski wants to merge 5 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/reorganize-home

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Moves the "Recently added" section into the right column on the Home page so it sits alongside the other supporting sections instead of the main content column.
  • Removes the Announcements section from Home entirely, along with its underlying data and copy.

Fixed Issues

$ #98653
PROPOSAL:

Tests

Offline tests

QA Steps

  1. Open the Home page on a wide screen (two-column layout) and verify the "Recently added" section now appears in the right column.
  2. Verify the Announcements section no longer appears anywhere on the Home page.
  3. Resize to a narrow/single-column layout and verify the Home page renders correctly with no missing or broken sections.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-17.at.17.34.42.mov

@melvin-bot

melvin-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@github-actions

Copy link
Copy Markdown
Contributor

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@JmillsExpensify

Copy link
Copy Markdown
Contributor

Adhoc looks great, we just need to incorporate the centered changes currently on main. @adamgrzybowski what's left to get this up for review?

…ganize-home

# Conflicts:
#	src/CONST/index.ts
#	src/pages/home/AnnouncementSection.tsx
@adamgrzybowski
adamgrzybowski marked this pull request as ready for review August 18, 2026 10:03
@adamgrzybowski
adamgrzybowski requested review from a team as code owners August 18, 2026 10:03
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team August 18, 2026 10:03
@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team August 18, 2026 10:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a63cb4d1a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread Mobile-Expensify Outdated
@adamgrzybowski
adamgrzybowski requested a review from a team as a code owner August 18, 2026 11:02
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@JmillsExpensify, it's ready for review

@shawnborton

Copy link
Copy Markdown
Contributor

Will run a test build.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@shawnborton

Copy link
Copy Markdown
Contributor

Can you merge main so we can see what this looks like centered up?

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@shawnborton isn't it merged? Adhoc build home looks centered to me
image

@shawnborton

Copy link
Copy Markdown
Contributor

Hmm I am seeing this in the adhoc:
CleanShot 2026-08-18 at 09 47 16@2x

@shawnborton

Copy link
Copy Markdown
Contributor

Actually ignore me, just did a hard refresh and we're good now!

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Do we want the lines going edge to edge, @shawnborton ?

CleanShot 2026-08-19 at 09 27 44@2x

It looks different to the mocks in the other issue.

@shawnborton

Copy link
Copy Markdown
Contributor

I think that might be how it currently is on mobile, and we are going to use mobile styles for all platforms now that we're in a smaller right column.

I have mixed feelings... part of me kinda likes it because it's similar to all of the other tables where lines go edge-to-edge. But it does feel a bit different from the other cards maybe... what do you think?

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

I think it's fine. I like the alignment vertically to the headline way better than what it was anyways. I think it looks good so let's maybe roll with it?

@shawnborton

Copy link
Copy Markdown
Contributor

Sweet, let's roll with it then 🎢

@JmillsExpensify
JmillsExpensify requested review from JmillsExpensify and removed request for garrettmknight August 19, 2026 08:15

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests really well. Approving for product. @ZhenjaHorbach can you jump in today? I'd like to try and get this merged around the same time as the Concierge improvement.

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Checking

@ZhenjaHorbach

ZhenjaHorbach commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

And after logging in, we have a bit of an empty screen with only one section on the right side

Снимок экрана — 2026-08-19 в 10 37 12

It didn't look so broken before

Снимок экрана — 2026-08-19 в 10 37 34

But maybe it's okay 😅
CC: @Expensify/design

@ZhenjaHorbach

ZhenjaHorbach commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-08-19.10.49.41.mov
Android: mWeb Chrome
2026-08-19.10.49.41.mov
iOS: HybridApp
2026-08-19.10.46.00.mov
iOS: mWeb Safari
2026-08-19.10.45.11.mov
MacOS: Chrome / Safari
2026-08-19.10.30.58.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

But overall changes look good

@JmillsExpensify

JmillsExpensify commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

And after logging in, we have a bit of an empty screen with only one section on the right side

Снимок экрана — 2026-08-19 в 10 37 12 It didn't look so broken before Снимок экрана — 2026-08-19 в 10 37 34 But maybe it's okay 😅 CC: @Expensify/design

I flagged this with design earlier today. Let's not block this PR on that is my vote. I'll create a separate issue and we can implement loaders.

@grgia
grgia self-requested a review August 19, 2026 09:12
@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

And after logging in, we have a bit of an empty screen with only one section on the right side
Снимок экрана — 2026-08-19 в 10 37 12
It didn't look so broken before
Снимок экрана — 2026-08-19 в 10 37 34
But maybe it's okay 😅 CC: @Expensify/design

I flagged this with design earlier today. Let's not block this PR on that is my vote. I'll create a separate issue and we can implement loaders.

Okay then
LGTM from my side!

@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@grgia grgia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@adamgrzybowski NAB

extra bottom padding on expenses when !hasExpenses makes the boxes slightly unevern

@github-actions

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98780.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Web 🕸️
https://98780.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

<WidgetContainer
title={translate('homePage.recentlyAddedSection.title')}
titleRightContent={overflowMenu}
containerStyles={shouldUseNarrowLayout ? styles.pb2 : styles.pb5}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants