Move Recently added to right column and remove Announcements from Home - #98780
Move Recently added to right column and remove Announcements from Home#98780adamgrzybowski wants to merge 5 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Adhoc looks great, we just need to incorporate the centered changes currently on main. @adamgrzybowski what's left to get this up for review? |
…ganize-home # Conflicts: # src/CONST/index.ts # src/pages/home/AnnouncementSection.tsx
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a63cb4d1a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@JmillsExpensify, it's ready for review |
|
Will run a test build. |
|
🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Can you merge main so we can see what this looks like centered up? |
|
@shawnborton isn't it merged? Adhoc build home looks centered to me |
|
Actually ignore me, just did a hard refresh and we're good now! |
|
Do we want the lines going edge to edge, @shawnborton ?
It looks different to the mocks in the other issue. |
|
I think that might be how it currently is on mobile, and we are going to use mobile styles for all platforms now that we're in a smaller right column. I have mixed feelings... part of me kinda likes it because it's similar to all of the other tables where lines go edge-to-edge. But it does feel a bit different from the other cards maybe... what do you think? |
|
I think it's fine. I like the alignment vertically to the headline way better than what it was anyways. I think it looks good so let's maybe roll with it? |
|
Sweet, let's roll with it then 🎢 |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Tests really well. Approving for product. @ZhenjaHorbach can you jump in today? I'd like to try and get this merged around the same time as the Concierge improvement.
|
Checking |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-08-19.10.49.41.movAndroid: mWeb Chrome2026-08-19.10.49.41.moviOS: HybridApp2026-08-19.10.46.00.moviOS: mWeb Safari2026-08-19.10.45.11.movMacOS: Chrome / Safari2026-08-19.10.30.58.mov |
|
But overall changes look good |
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
grgia
left a comment
There was a problem hiding this comment.
@adamgrzybowski NAB
extra bottom padding on expenses when !hasExpenses makes the boxes slightly unevern
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
| <WidgetContainer | ||
| title={translate('homePage.recentlyAddedSection.title')} | ||
| titleRightContent={overflowMenu} | ||
| containerStyles={shouldUseNarrowLayout ? styles.pb2 : styles.pb5} |







Explanation of Change
Fixed Issues
$ #98653
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-17.at.17.34.42.mov