refactor getDisplayNameForParticipant function to use hiddenTranslation - #98749
refactor getDisplayNameForParticipant function to use hiddenTranslation#98749daledah wants to merge 3 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| translate?: LocalizedTranslate; | ||
| /** | ||
| * Pre-resolved "Hidden" string, passed instead of a `translate` fn. Callers resolve it once (e.g. `translate('common.hidden')`, | ||
| * hoisted out of loops) and pass the value; English-only persisted messages pass the English literal. Defaults to the cached |
There was a problem hiding this comment.
❌ CONSISTENCY-16 (docs)
This JSDoc description uses a semicolon to join two independent clauses ("...and pass the value; English-only persisted messages pass the English literal..."). Per the plain-comment-style rule, a semicolon should be replaced with two separate sentences so the comment reads like natural prose.
Split it into two sentences, for example:
/**
* Pre-resolved "Hidden" string, passed instead of a `translate` fn. Callers resolve it once (e.g. `translate('common.hidden')`,
* hoisted out of loops) and pass the value. English-only persisted messages pass the English literal. Defaults to the cached
* module value when omitted. Mirrors `getPolicyName`'s `unavailableTranslation`.
*/Reviewed at: e32e579 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Explanation of Change
Fixed Issues
$ #66430
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-09.at.01.51.29.mov