Skip to content

Add August product marketing window - #98565

Open
KJ21-ENG wants to merge 6 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/98233-august-product-marketing-window
Open

Add August product marketing window#98565
KJ21-ENG wants to merge 6 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/98233-august-product-marketing-window

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Replaces the July product marketing announcement with the August admin and eligible member variants and their supplied images. The admin CTA uses the selected admin workspace's hydrated accounting connections to route to Vendors when enabled, or safely falls back to More Features while offline or after a failed connection refresh. Members with Custom Agent access can open the new Agents flow without bypassing its beta boundary. Dismissal remains campaign-keyed and is persisted before navigation.

Fixed Issues

$ #98233
PROPOSAL: #98233 (comment)

Tests

  1. Verify that no errors related to ProductMarketingWindow appear in the JS console.
  2. Sign in with a fresh member account that has Custom Agent beta access and is not an admin of any active workspace.
  3. Verify the Pre-built agents for you window appears with the employee image and Dismiss / Try it out actions.
  4. Press Try it out, verify the new Agents page opens, and verify the window is dismissed before navigation and does not reappear after reload.
  5. Remove Custom Agent beta access from the member account and verify the member window is not shown.
  6. Sign in with an admin account whose selected admin workspace does not have Vendors enabled.
  7. Verify the Enhanced vendor mapping window appears with the admin image, then press Try it out and verify the workspace More Features page opens.
  8. Repeat with a workspace that has the Vendor Matching beta and a supported accounting connection configured.
  9. Verify Try it out opens that workspace's Vendors page after its connection data finishes loading.
  10. Make a non-admin workspace active while the account administers another active workspace. Verify the CTA stays disabled while the fallback workspace's connections load, then routes using the fallback admin workspace.
  11. Dismiss the window, reload, and verify the August window stays dismissed. With an account whose last dismissed campaign is July, verify the August window still appears.
  • Verify that no errors related to ProductMarketingWindow appear in the JS console

Offline tests

  1. Use an admin account where the active workspace is not administered but another active workspace is.
  2. Go offline before the fallback workspace's accounting connections are fetched.
  3. Verify the admin CTA remains actionable and opens More Features instead of assuming Vendors is enabled or showing an error.
  4. Restore the network, let the connection data load, and verify the destination follows the workspace's actual Vendors state.

QA Steps

  1. Repeat Tests 1-11 on staging with fresh member and admin accounts, including member accounts with and without Custom Agent beta access.
  2. For the direct Vendors case, use an admin workspace with Vendor Matching beta access and a supported accounting connection.
  3. Verify the fallback More Features destination remains visible and actionable for the intended campaign recipient; enabling Vendors is tracked separately from this PR.
  4. Repeat the Offline tests and verify no incorrect Vendors destination or error page appears.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Record_2026-08-16-03-39-38_40d2c9e2d8fb5b5aba3904834590021e.compressed.mp4
Android: mWeb Chrome
Record_2026-08-15-12-10-46.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-08-15.at.17.24.55.compressed.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-08-15.at.14.26.29.compressed.mp4
MacOS: Chrome / Safari

Pre-review POC evidence from the earlier candidate. This does not replace final-head, all-platform recordings.

Member marketing window:

Member marketing window

Admin marketing window:

Admin marketing window

More Features fallback:

More Features fallback

Direct Vendors destination:

Direct Vendors destination

Video:

Screen.Recording.2026-08-13.at.11.43.16.AM.compressed.mp4

@melvin-bot

melvin-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@KJ21-ENG
KJ21-ENG marked this pull request as ready for review August 15, 2026 22:23
@KJ21-ENG
KJ21-ENG requested review from a team as code owners August 15, 2026 22:23
@melvin-bot
melvin-bot Bot requested review from a team, huult and joekaufmanexpensify and removed request for a team August 15, 2026 22:23
@melvin-bot

melvin-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team August 15, 2026 22:23
@melvin-bot

melvin-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
.../ProductMarketingWindow/ProductMarketingWindow.tsx 100.00% <100.00%> (ø)
src/libs/ProductMarketingWindowUtils.ts 100.00% <100.00%> (ø)
...tMarketingWindow/ProductMarketingWindowManager.tsx 97.67% <90.90%> (-2.33%) ⬇️
... and 197 files with indirect coverage changes

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Screenshots and videos look good to me 👍

@shawnborton

Copy link
Copy Markdown
Contributor

Video looks good to me. In the future, it might be nice to have a little spinner while the image loads:
CleanShot 2026-08-16 at 20 15 52@2x

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Great shout 👍 I like that idea. Would be nice to make a follow-up on that now cause we'll keep updating this each month I assume?

@shawnborton

Copy link
Copy Markdown
Contributor

Yup that makes sense. @KJ21-ENG thoughts on the idea before I make an issue?

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@shawnborton I loved the idea, as it had seemed off to me since last month when I was working on implementing this marketing window. All this time I had been thinking about how to make it load faster😅, but the spinner now makes more sense to me as well :)

cc: @dubielzyk-expensify

@huult

huult commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@shawnborton @dubielzyk-expensify Do you need an ad hoc build to test?

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Thoughts ?

Screen.Recording.2026-08-17.at.10.14.49.AM.compressed.mp4

cc: @shawnborton @dubielzyk-expensify @huult

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Thoughts ?

That looks good.

@shawnborton @dubielzyk-expensify Do you need an ad hoc build to test?

I'll kick one off

@github-actions

Copy link
Copy Markdown
Contributor

🚧 dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@huult

huult commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Can someone help run this translation?

@huult

huult commented Aug 17, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-08-17.at.12.45.19.mov

@shawnborton When the Product Marketing Window is showing the Admins Case Window and we delete all workspaces, it changes to the Employee Case Window because there’s no workspace. Is this expected behavior, or should we hide the Product Marketing Window instead?

@huult

huult commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp Screenshot 2026-08-17 at 13 00 48 Screenshot 2026-08-17 at 13 01 29
Android: mWeb Chrome Screenshot 2026-08-17 at 13 02 45 Screenshot 2026-08-17 at 13 05 53
iOS: HybridApp Screenshot 2026-08-17 at 13 09 27 Screenshot 2026-08-17 at 13 10 27
iOS: mWeb Safari Screenshot 2026-08-17 at 13 07 22 Screenshot 2026-08-17 at 13 11 18
MacOS: Chrome / Safari
Screen.Recording.2026-08-17.at.12.51.56.mp4

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Screen.Recording.2026-08-17.at.12.45.19.mov
@shawnborton When the Product Marketing Window is showing the Admins Case Window and we delete all workspaces, it changes to the Employee Case Window because there’s no workspace. Is this expected behavior, or should we hide the Product Marketing Window instead?

IMO, I think the current behavior makes sense and this is more of a product decision. Once the last workspace is deleted, the user no longer matches the Admin audience and now matches the Employee audience, so switching the window feels more consistent than hiding it. Hiding it here would add a special suppression path even though the user hasn’t dismissed or acted on the campaign.

cc: @huult @shawnborton

@shawnborton

Copy link
Copy Markdown
Contributor

That makes sense to me. What about the cases where you are admin of one workspace but an employee on another - how are we handling that?

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@shawnborton In that mixed case, the admin variant takes precedence. We check whether the user is an admin of any active workspace. If the currently active workspace is one they administer, the CTA uses that workspace; otherwise, we fall back to their first active admin workspace. The employee variant is only shown when they aren’t an admin of any active workspace, so being an employee in another workspace won’t change the targeting or point the CTA somewhere they lack admin access.

cc: @huult

@shawnborton

Copy link
Copy Markdown
Contributor

Interesting, I kinda think the employee case is still important to show (specifically in this case for agents). I would think we should do something where we display the employee modal maybe X days after the admin modal was dismissed or something? cc @Expensify/product @danielrvidal for thoughts there.

@shawnborton

Copy link
Copy Markdown
Contributor

(The image loading spinner looks great btw, thanks for squeezing that in here!)

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

I would think we should do something where we display the employee modal maybe X days after the admin modal was dismissed or something?

Quite interesting; eager to hear what others think.

@garrettmknight
garrettmknight removed their request for review August 17, 2026 16:53

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for product

@huult

huult commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

#98565 (comment) Still waiting for the final decision.

@huult

huult commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

(The image loading spinner looks great btw, thanks for squeezing that in here!)

@KJ21-ENG Did you update the loading spinner in this PR? I didn’t see the change.

@danielrvidal

Copy link
Copy Markdown
Contributor

Interesting, I kinda think the employee case is still important to show (specifically in this case for agents). I would think we should do something where we display the employee modal maybe X days after the admin modal was dismissed or something? cc @Expensify/product @danielrvidal for thoughts there.

I'm not passionate about showing it twice. We're going to be doing these once a month already at a minimum with the product updates so it feels like it could be a lot if there are always feature advertisements. I'm also not passionate about not doing them. @JmillsExpensify might have some thoughts though too.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Video looks good to me. In the future, it might be nice to have a little spinner while the image loads:

Yup that makes sense. @KJ21-ENG thoughts on the idea before I make an issue?

Thoughts ?
https://github.com/user-attachments/assets/7601eb93-f30a-4b64-8bb2-849367f30277
cc: @shawnborton @dubielzyk-expensify @huult

(The image loading spinner looks great btw, thanks for squeezing that in here!)

@KJ21-ENG Did you update the loading spinner in this PR? I didn’t see the change.

Ahh, strange, seems like due to yesterday's GitHub downtime, my comment did not get published and fell in draft.

Actually, I haven't pushed it to this PR yet. I was asking whether I should push it in this PR itself or we should handle it in a separate issue/PR for better traceability. I am OK with both of them, as I have changes ready in my local.

cc: @shawnborton @huult @joekaufmanexpensify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants