Skip to content

[Payment due @truph01] Docs updates for E/A#98161 document Download workflows option on Workflows page - #98479

Open
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsDownloadWorkflows
Open

[Payment due @truph01] Docs updates for E/A#98161 document Download workflows option on Workflows page#98479
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsDownloadWorkflows

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs update for #98161

#98161 adds a Download workflows option to the More dropdown on Workspace > Workflows, letting admins export their workflow configuration as a CSV. The Workspace Workflows help article didn't document this (or the More menu) at all, so this PR adds a short task-based section covering it.

What changed

  • Added a How to download your workflow configuration section to docs/articles/new-expensify/workspaces/Workspace-Workflows.md with steps to open Workflows > More > Download workflows, plus a note on the offline behavior.

Label verification

UI labels used in the article (Workflows tab, More button, Download workflows item) were taken verbatim from the strings shipped in #98161 (common.more, spreadsheet.downloadWorkflows). I was unable to confirm them against the live UI because the test session wasn't authenticated during this run, so please double-check the exact on-screen labels when reviewing.

@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: truph01 <truph01@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 12, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the failing checks. There's nothing to fix here with a code change.

The only failing check is Check independent approval — every real CI check is passing (check, verify, dryRun, spellcheck, validate, verifySignedCommits, etc.).

That check isn't a build/test failure. It fails because this PR was opened by MelvinBot and still needs an approval from an independent human reviewer (someone other than the author). It will turn green automatically once the PR is reviewed and approved — there's no branch change that can clear it.

Next step: review the changed docs and, once they look right, mark the PR ready for review and approve it (or have another reviewer approve). Per the PR description, you can also reply with @MelvinBot mark this PR as ready for review.

@truph01

truph01 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready

@MelvinBot
MelvinBot marked this pull request as ready for review August 17, 2026 08:27
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Done — this PR is now marked Ready for review. 🚀

One reminder from the PR description: the UI labels (Workflows tab, More button, Download workflows item) were taken verbatim from the strings in #98161 but couldn't be confirmed against the live UI during authoring, so please give those a final glance during review.


---

## How to download your workflow configuration

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI readiness / feature naming: Task-based headings must use the exact UI feature name (HELP_AUTHORING_GUIDELINES.md Sections 2 & 6). "workflow configuration" is not a UI label. Consider ## How to download your Workflows configuration or ## How to download workflows, matching the Download workflows option and the Workflows page.


You can export your workspace's workflow configuration to a CSV file—for example, to review approver assignments or keep an offline record. Admins who can manage workflows will see the **More** menu on the **Workflows** page.

1. In the navigation tabs (on the left on web, and at the bottom on mobile), click **Workspaces > [Workspace name] > Workflows**.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation phrasing: The unified navigation sentence must read exactly "In the navigation tabs (on the left on web, on the bottom on mobile)" per HELPSITE_NAMING_CONVENTIONS.md (Navigation Instruction Standards). Remove the extra wording so it is "(on the left on web, on the bottom on mobile)" — drop "and at the bottom" in favor of "on the bottom".

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single, focused task-based section (## How to download your workflow configuration) to docs/articles/new-expensify/workspaces/Workspace-Workflows.md, documenting the new Download workflows option in the More menu on the Workflows page. The addition is small, self-contained, and matches the existing article style well.

Scores Summary

  • Readability: 9/10 - Clear, concise, well-sequenced numbered steps with a helpful offline note. Reads cleanly and is easy to scan.
  • AI Readiness: 9/10 - Task-based How to heading, single workflow, heading hierarchy kept to second-level only, and placed correctly before the FAQ. Article-level YAML metadata (including internalScope) is present and unchanged.
  • Style Compliance: 8/10 - UI labels (Workflows, More, Download workflows) are bolded in Sentence case, and the unified web/mobile navigation sentence matches the naming conventions and the rest of the article.

Key Findings

  • Positive: New section follows one-workflow-per-section, uses the correct unified navigation phrasing (on the left on web, and at the bottom on mobile), and keeps to top-level and second-level headings only.
  • Positive: The offline-behavior note is genuinely useful and precise.
  • Minor: The heading task phrase (download your workflow configuration) differs slightly from the exact UI item (Download workflows); the steps use the exact label correctly, so this is low-severity.
  • Minor: The intro line about admins who can manage workflows seeing the More menu is vaguer than the precise role terminology used elsewhere (Workspace Admins / People Admins / Payments Admins). Consider tightening for consistency.
  • Minor: member and approval workflow details in the result sentence is slightly generic; naming exactly what the CSV contains would help.
  • Note (from PR author): UI labels were taken from shipped strings but not verified against the live UI, so the reviewer should confirm the exact on-screen labels.

Recommendations

  • Confirm the exact on-screen labels (More, Download workflows) against the live UI before merge.
  • Optionally align the intro role reference with the established role terms for precision.
  • Optionally clarify the exact contents of the exported CSV.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Workspace-Workflows.md - Approve with minor suggestions; 14 additions, well-structured and compliant.

Note: This is a summary review of the proposed diff only.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbd909c0f5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


## How to download your workflow configuration

You can export your workspace's workflow configuration to a CSV file—for example, to review approver assignments or keep an offline record. Admins who can manage workflows will see the **More** menu on the **Workflows** page.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Exclude Payments Admins from the More-menu audience

For a Payments Admin, this wording implies that the More menu is available because they can manage the Payments workflow, but WorkspaceWorkflowsPage.tsx:1110 renders the menu only when canWriteApprovals is true, while PolicyUtils.ts:184-189 grants Payments Admins only WORKFLOWS_PAYMENTS write access. Limit this statement to roles with approval-workflow write access so Payments Admins are not directed to a control they cannot see.

Useful? React with 👍 / 👎.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Nothing to fix here — there's no code failure to push a fix for.

The only failing check is Check independent approval, and it's failing simply because the PR doesn't yet have an independent reviewer's approval (reviewDecision: REVIEW_REQUIRED). It's a merge-gate policy check, not a code/test failure — pushing a commit won't clear it. Every other check passes or is skipped.

To clear it: this PR needs an approval from an independent reviewer (someone other than the author). Since it's a HelpDot docs change, once you've reviewed the files and confirmed they reflect the current behavior, get a reviewer to approve it and the check will pass.

Full check status
  • Check independent approval — awaiting independent human approval (not code-fixable)
  • CLA, check, dryRun, review, validate, verify, spellcheck, checklist, verifySignedCommits, Request reviewers for new Onyx.connectWithoutView calls
  • ⏭️ actionlint, approveAndMerge, validateImmutableActionRefs, validateSchemas — skipped

@melvin-bot melvin-bot Bot changed the title Docs updates for E/A#98161 document Download workflows option on Workflows page [Payment due @truph01] Docs updates for E/A#98161 document Download workflows option on Workflows page Aug 17, 2026
@melvin-bot

melvin-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

🎯 @truph01, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants