[Payment due @truph01] Docs updates for E/A#96567 note Smart Limit needs approval workflow - #98476
[Payment due @truph01] Docs updates for E/A#96567 note Smart Limit needs approval workflow#98476MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: truph01 <truph01@users.noreply.github.com>
|
The only failing check is Check independent approval, and there's nothing to push a fix for. That check isn't a build/lint/test failure — it's an approval gate that stays red until someone other than the PR author approves the PR. Every actual CI check ( To clear it: have a reviewer approve the PR. Once this docs update is reviewed and confirmed accurate, it'll go green on its own — no code change is needed from me. |
|
@MelvinBot mark this PR as ready |
|
🤖 Done — this PR is now marked Ready for review (draft status removed). Since this is a docs-only change (two |
| 4. Choose **Virtual** or **Physical** | ||
| 5. Choose a limit type: | ||
| - **Smart limit**: Spend up to a threshold before needing approval | ||
| - **Smart Limit**: Spend up to a certain amount before requiring approval. This option requires an approval workflow, so it appears disabled if your workspace’s approvals are set to **Optional**. Enable approvals to select it. |
There was a problem hiding this comment.
Cross-linking violation (HELP_AUTHORING_GUIDELINES.md Section 7): "Enable approvals" is a dependency the reader must act on to unblock this option, and in the UI it is a hyperlink. Per the Cross-Linking Standards it should be a relative cross-link with descriptive anchor text (e.g. [learn how to enable approvals](/articles/new-expensify/workspaces/Add-Approvals.md)) rather than plain prose. Also, per the Deterministic Writing Rule, avoid the vague pronoun "select it" — mirror the UI wording "select this option".
| 4. Choose **Virtual** or **Physical**. | ||
| 5. Choose a spending limit type: | ||
| - **Smart limit** – Spend up to a threshold before approval is required. | ||
| - **Smart Limit** – Spend up to a certain amount before requiring approval. This option requires an approval workflow, so it appears disabled if your workspace’s approvals are set to **Optional**. Enable approvals to select it. |
There was a problem hiding this comment.
Cross-linking violation (HELP_AUTHORING_GUIDELINES.md Section 7): "Enable approvals" is a dependency the reader must act on to unblock this option, and in the UI it is a hyperlink. Per the Cross-Linking Standards it should be a relative cross-link with descriptive anchor text (e.g. [learn how to enable approvals](/articles/new-expensify/workspaces/Add-Approvals.md)) rather than plain prose. Also, per the Deterministic Writing Rule, avoid the vague pronoun "select it" — mirror the UI wording "select this option".
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
I looked into the failing checks. There's nothing to fix in the code — all substantive checks ( The only red check is Check independent approval, which isn't a code failure. It's a policy gate that stays red until a human reviewer other than the PR author approves the PR. Because this PR was opened by MelvinBot, it has no independent approval yet, so the check will keep failing until someone reviews and approves it. Next step: |
|
🎯 @truph01, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
Re-checked — nothing changed and there's still no code fix to push. Every substantive check passes ( The only red check is Check independent approval, which is a policy gate, not a code failure. It stays red until a reviewer other than the PR author approves this PR. Since it was opened by MelvinBot, it has no independent approval yet. Next step: |
Docs updates for E/A#96567
Why
Expensify/App#96567 changes the Expensify Card limit type selector so that Smart Limit is no longer hidden when a workspace uses Optional approvals — instead it is always shown but disabled, with a note that an approval workflow must be enabled to select it.
The New Expensify card setup articles listed Smart Limit as a selectable limit type but never mentioned that it depends on an approval workflow. This update documents that requirement so the help site matches the new UI behavior.
Changes
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-US.md— updated the Smart Limit limit-type bullet to note it requires an approval workflow and appears disabled when approvals are Optional.docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card-UK-EU.md— same update.I also corrected the label capitalization to Smart Limit (capital L) to match the product UI (
smartLimit: 'Smart Limit'), per the naming conventions.Notes
src/languages/en.ts(smartLimit,smartLimitDescription,smartLimitDisabledDescription). I was not able to confirm against a live UI session because the test session landed logged-out, so please double-check the wording against the current UI.Cardholder-Settings-and-Features.md,Troubleshoot-Expensify-Card-issues.md) describe Smart Limit from the cardholder's perspective and are not affected by this admin-facing selector change, so they were left unchanged.@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.