[Payment due @QichenZhu] [No QA] Docs updates for E/A#97486 extend Book a call to partner manager and guide - #98471
Conversation
Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
|
🤖 No code fix needed here — the only failing check is Check independent approval, which isn't a code issue I can fix by pushing to the branch. This is a governance gate: it fails until someone other than the PR author approves the PR. Since this is a docs-only change, it just needs an independent reviewer to approve. Once you (or another reviewer) approve, this check turns green on its own. Everything else is green ( Next step: mark the PR ready for review and get an independent approval — no branch changes required. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot mark the PR as ready for review. |
|
🤖 Done — this PR is now marked Ready for review. |
| @@ -247,7 +249,7 @@ Account Managers are typically assigned to accounts with subscriptions that incl | |||
|
|
|||
| ## Why don't I see the Book a call button? | |||
There was a problem hiding this comment.
Readability: This FAQ answer packs multiple conditions (assignment, scheduling link, Concierge precedence order, Guide/Account Manager exclusivity) into one dense run-on paragraph, which hurts scannability (HELP_AUTHORING_GUIDELINES.md Section 1 — concise and actionable). Consider breaking the Concierge precedence rule into a short bulleted list, e.g. Account Manager -> Partner Manager -> Guide, with the note that the Guide's button only shows when no Account Manager is assigned.
There was a problem hiding this comment.
Addressed — rather than reformat the precedence rule as a list, I removed the technical ordering per QichenZhu's feedback. The FAQ answer now ends simply with "In Concierge, only one Book a call button shows at a time," which resolves the dense run-on. (Navigating-New-Expensify.md:252)
HelpDot Documentation ReviewOverall AssessmentThis PR extends the existing Book a call guidance in Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review. No blocking issues were found. |
|
@MelvinBot address the review comments. |
…precedence order Co-authored-by: Krishna Chaitanya <c3024@users.noreply.github.com>
|
Addressed all four review comments in
Replied inline on each thread as well. Docs-only change, so no app tests were required. |
|
A preview of your ExpensifyHelp changes have been deployed to https://96ef676e.helpdot.pages.dev ⚡️ Updated articles: |
|
There's nothing to fix here — no CI check is actually broken. The only check reporting All other checks are green now (the
Next step: this just needs an independent reviewer's approval to turn |
|
🎯 @QichenZhu, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@stephanieelliott could you review this? |
|
The only failing check is Check independent approval — there's no code or test failure here, so there's nothing to push a fix for. Every real check (
To resolve: this needs a human action, not a code change — get the required independent approval (e.g. an eligible reviewer/reviewer-team approval on the latest commit). Once that lands, the check will clear on its own. |
|
@stephanieelliott could you please review this? |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.55-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.55-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
#97486 extends the external Book a call button (Calendly scheduling link) from the Account Manager to the Partner Manager and Guide as well, on both the Help page and in chat headers (Concierge and 1:1 DMs). This updates the help site to reflect that behavior.
Updated
Navigating-New-Expensify.md, which previously documented Book a call only for the Account Manager:Fixed Issues
Docs update for #97486
Tests
Documentation-only change. Verify the rendered article reads correctly and the Book a call guidance matches the current app behavior.
QA Steps
Same as Tests.
@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.