Add Paid by search filter UI, table column, sorting, and export by c3024 · Pull Request #98326 · Expensify/App

c3024 · 2026-08-11T16:02:51Z

Explanation of Change

Adds a new paidBy: filter (also typable as paid-by:, like expense-type:) to the advanced filters and filter bar as a multi-select user filter for expense, expense report, invoice, and trip searches. It matches the user who actually paid a report. The existing payer: filter (the responsible payer, powering the Pay to-do) is unchanged and stays hidden from the filters UI, per the Slack naming decision.
Adds a Paid by column to expense report search views, derived from the actor of the latest payment report action in the snapshot (same pattern as First approver), with sorting and CSV export support.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/670393
PROPOSAL:

Tests

Sign in as a workspace member who has paid reports.
Go to Reports > Expense reports and open the columns picker. Enable the Paid by column.
Verify the Paid by column shows the person who paid each paid report and is blank for unpaid reports.
Click the Paid by column header and verify the rows sort by that name.
Open Filters, choose Paid by, select one or more users, and apply.
Verify the results only include reports paid by the selected users (unpaid reports never match), and the filter bar shows a Paid by chip.
Select the paid reports and click on Export from the selected drop down > Current View. Verify the exported file has a Paid by column with the name of the user who paid.

Screen.Recording.2026-08-17.at.3.41.21.PM.mov

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

The payer filter is now shown in the advanced filters and filter bar as a multi-select user filter, and a Payer column is available on expense report search views. The column is derived from the actor of the latest payment report action returned in the search snapshot, matching how First approver is derived, and is sortable and exportable.

melvin-bot · 2026-08-11T16:02:56Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-08-11T16:17:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`94.85% <ø> (ø)`
...ents/Search/FilterComponents/ListFilterContent.tsx	`0.00% <ø> (ø)`
src/components/Search/SearchList/ListItem/types.ts	`100.00% <ø> (ø)`
...onents/Search/SearchPageHeader/SearchFilterBar.tsx	`2.85% <ø> (ø)`
...nents/Search/SearchRouter/buildSubstitutionsMap.ts	`100.00% <100.00%> (ø)`
...s/Search/SearchRouter/getQueryWithSubstitutions.ts	`96.96% <ø> (ø)`
src/components/Search/SearchTableHeader.tsx	`49.43% <ø> (ø)`
src/hooks/useAdvancedSearchFilters.ts	`97.50% <ø> (ø)`
src/hooks/useAutocompleteSuggestions.ts	`73.00% <ø> (ø)`
src/libs/SearchAutocompleteUtils.ts	`63.29% <100.00%> (+0.19%)`	⬆️
... and 7 more
... and 13 files with indirect coverage changes

Matches the backend gate on report status, so canceled or reopened reports fall back to having no payer column value.

The payer filter keeps its existing responsible-payer meaning (hidden from the filters UI as before) and the payment-actor work moves to a new paidBy filter key, table column, and translations. The paid-by syntax also accepts paid-by: like the other multi-word keys.

…shot

melvin-bot · 2026-08-17T11:59:05Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

…r-search-filter # Conflicts: # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/searchParser.js

…a/670393-payer-search-filter

melvin-bot · 2026-08-18T11:37:24Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-08-18T11:41:13Z

                const formattedTo = !shouldShowBlankTo ? temporaryGetDisplayNameOrDefault({passedPersonalDetails: toDetails, translate, formatPhoneNumber}) : '';
                const formattedFirstApprover = firstApproverAccountID ? temporaryGetDisplayNameOrDefault({passedPersonalDetails: firstApproverDetails, translate, formatPhoneNumber}) : '';

+                // The paid-by user is the actor on the latest payment action; blank until the report is paid.


❌ CONSISTENCY-16 (docs)

Comments should read like plain, natural sentences. This comment joins two clauses with a semicolon instead of using two separate sentences, which CONSISTENCY-16 flags.

Split it into two sentences:

// The paid-by user is the actor on the latest payment action. It stays blank until the report is paid. const lastReimbursedAction = lastReimbursedActionByReportID.get(reportItem.reportID);

Reviewed at: 03abca5 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03abca58f7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-18T11:43:22Z

 const FILTER_COMPONENT_MAP: Partial<Record<SearchFilter['key'], React.ComponentType<DropdownProps>>> = {
    [CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM]: UserDropdown,
    [CONST.SEARCH.SYNTAX_FILTER_KEYS.TO]: UserDropdown,
+    [CONST.SEARCH.SYNTAX_FILTER_KEYS.PAID_BY]: UserDropdown,


Preserve paid-by IDs for the user dropdown

When a Paid by filter is applied, getDisplayValue() does not classify PAID_BY/PAID_BY_NOT with the other user filters, so it joins the account-ID array into a string before this mapping passes it to UserDropdown. useFilterUserValue() explicitly returns no names for non-array input, leaving the Paid by filter chip/dropdown value blank even though the filter is active. Preserve the ID array for both paid-by keys as is done for From and To.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-08-18T11:43:22Z

+    [CONST.SEARCH.SYNTAX_FILTER_KEYS.PAID_BY]: {
+        labelKey: 'search.filters.paidBy',
+        icon: 'MoneyBag',
+    },


Render paid-by values through the user formatter

Adding Paid by to FILTER_VIEW_MAP makes it appear in the applied-filters list on the save-search page, but SearchSavePage.FilterValue does not recognize this key as a user filter. Consequently, saving a search with Paid by selected displays raw account IDs rather than the users' names; route PAID_BY through FilterUserValue alongside From, To, Attendee, and Assignee.

Useful? React with 👍 / 👎.

shawnborton · 2026-08-18T13:42:41Z

Let us know when you have videos to review.

joekaufmanexpensify

Great addition. Excited for this!

melvin-bot Bot assigned c3024 Aug 11, 2026

quinthar added the #migrate label Aug 11, 2026

c3024 added 8 commits August 12, 2026 13:12

Ignore canceled payments when deriving the payer column

0c5e6f1

Void the payer on ACH cancellations and bounces too

b4fd2f2

Ignore owner receipt confirmations when deriving the payer column

1e64d43

Break payer action ties by reportActionID to match the backend

d375094

Resolve the payer from payment actions only on paid reports

c20a981

Matches the backend gate on report status, so canceled or reopened reports fall back to having no payer column value.

Resolve self-payments as payer unless the owner confirmed receipt

70d2cce

Bound the owner receipt-confirmation check to the payment action time

9577829

c3024 changed the title ~~Add Payer search filter UI, table column, sorting, and export~~ Add Paid by search filter UI, table column, sorting, and export Aug 12, 2026

Show paid-by as the user-friendly key in search suggestions

c6194f2

quinthar removed the #migrate label Aug 13, 2026

Simplify paid-by derivation to the payment action shipped in the snap…

38d41c7

…shot

c3024 added 2 commits August 17, 2026 18:21

Merge remote-tracking branch 'origin/main' into chaitanya/670393-paye…

03abca5

…r-search-filter # Conflicts: # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/searchParser.js

Merge remote-tracking branch 'refs/remotes/origin/main' into chaitany…

eb3ee09

…a/670393-payer-search-filter

c3024 marked this pull request as ready for review August 18, 2026 11:37

c3024 requested review from a team as code owners August 18, 2026 11:37

melvin-bot Bot requested a review from hoangzinh August 18, 2026 11:37

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team August 18, 2026 11:37

github-actions Bot reviewed Aug 18, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Aug 18, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Aug 18, 2026

View reviewed changes

Fix paid-by filter display in filter bar and saved search page

159592d

c3024 dismissed joekaufmanexpensify’s stale review via 159592d August 19, 2026 16:40

Navigation Menu

Uh oh!

Add Paid by search filter UI, table column, sorting, and export - #98326

Add Paid by search filter UI, table column, sorting, and export#98326
c3024 wants to merge 14 commits into
Expensify:mainfrom
c3024:chaitanya/670393-payer-search-filter

c3024 commented Aug 11, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Aug 11, 2026

Uh oh!

codecov Bot commented Aug 11, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Aug 17, 2026

Uh oh!

melvin-bot Bot commented Aug 18, 2026

Uh oh!

github-actions Bot Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Uh oh!

shawnborton commented Aug 18, 2026

Uh oh!

joekaufmanexpensify left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

c3024 commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 11, 2026

Uh oh!

codecov Bot commented Aug 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Aug 17, 2026

Uh oh!

melvin-bot Bot commented Aug 18, 2026

Uh oh!

github-actions Bot Aug 18, 2026

Choose a reason for hiding this comment

❌ CONSISTENCY-16 (docs)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Aug 18, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c3024 commented Aug 11, 2026 •

edited

Loading

codecov Bot commented Aug 11, 2026 •

edited by github-actions Bot

Loading