Skip to content

[No QA] Docs updates for E/A#96623 scope Time-sensitive alert card qualifier - #98211

Open
MelvinBot wants to merge 2 commits into
mainfrom
claude-docsHomeTimeSensitiveAlertScope
Open

[No QA] Docs updates for E/A#96623 scope Time-sensitive alert card qualifier#98211
MelvinBot wants to merge 2 commits into
mainfrom
claude-docsHomeTimeSensitiveAlertScope

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up docs correction for the Home change in #96623, which added a new Time-sensitive to-do ("Add a bank account to get reimbursed") that appears when an ACH reimbursement is queued for a payee who has no personal deposit account.

That PR already documented the new alert in Expensify-Home-Overview.md by adding this bullet to the "These alerts appear when" list:

  • A reimbursement is waiting for the payee to add a personal deposit account

However, the sentence directly beneath that list still said:

Alerts are only shown for active Expensify Cards. Deactivated or closed cards do not trigger time-sensitive alerts.

That blanket statement is inaccurate now that the Time-sensitive section covers non-card alerts (blocked workflows, locked bank accounts, and this new reimbursement/deposit-account alert). The "active card" qualifier only applies to the Expensify Card fraud alert. This PR scopes it accordingly:

Expensify Card fraud alerts are only shown for active cards. Deactivated or closed cards do not trigger these alerts.

Only the one qualifier sentence is changed — no other content is touched.

Related


@sharabai, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Sergei Sharabai <sharabai@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 10, 2026
Comment thread docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md Outdated
@sharabai

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

There's no code fix to push here — the only failing check is Check independent approval, and it's not a code failure.

That check is a review gate: it stays red until an independent reviewer (someone other than the author) submits an Approve review. Right now reviewDecision is REVIEW_REQUIRED — the only review on the PR so far is a COMMENTED review, not an approval. Every other check (check, verify, validate, spellcheck, dryRun, CLA, signed commits) is green.

Since this is a 1-line docs change and all real CI checks pass, the PR just needs an independent approval to clear that gate. Nothing for me to change on the branch.

…rview.md

Co-authored-by: Sergei Sharabai <105950333+sharabai@users.noreply.github.com>
@stephanieelliott
stephanieelliott marked this pull request as ready for review August 18, 2026 06:28
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 18, 2026 06:28
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a single, targeted, one-line correction in Expensify-Home-Overview.md. It scopes a previously inaccurate blanket statement so the "active card" qualifier now applies only to Expensify Card alerts rather than to all Time-sensitive alerts. This is a correct and well-justified accuracy fix, consistent with the surrounding list that now covers non-card alerts (blocked workflows, locked bank accounts, and the new reimbursement/deposit-account alert).

Scores Summary

  • Readability: 9/10 - The revised sentence is clear, concise, and scannable. "Expensify Card alerts are only shown for active cards. Deactivated or closed cards do not trigger these alerts." reads cleanly and reduces redundancy ("active Expensify Cards" to "active cards").
  • AI Readiness: 8/10 - Uses the full feature name ("Expensify Card") and improves factual precision, which helps semantic retrieval by no longer over-generalizing card behavior to all alerts. The change sits in an existing, correctly structured section; no metadata or heading concerns are introduced by the diff.
  • Style Compliance: 9/10 - Uses exact feature terminology ("Expensify Card") per the naming conventions and avoids vague/generalized language. No button, tab, or navigation phrasing is involved. Fully compliant with the UI-referencing rules relevant to this change.

Key Findings

  • The correction is accurate: the source list includes non-card alerts, so the prior blanket "active Expensify Cards" statement was misleading. Scoping it resolves that.
  • Positive: minimal, surgical change with no scope creep; only the one qualifier sentence is touched.
  • Minor note (optional, not blocking): the qualifier now applies specifically to the fraud alert ("suspected Expensify Card fraud on an active card"). Wording it as "Expensify Card fraud alerts..." would be marginally more precise, but "Expensify Card alerts" is acceptable and reads well.

Recommendations

  • Approve. No required changes.
  • Optional: consider "Expensify Card fraud alerts are only shown for active cards..." to tie the qualifier directly to the single card-related bullet.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md - One-line accuracy correction. Compliant and approved.

Note: This change is a single line; no additional inline comments were warranted.

@github-actions github-actions Bot changed the title Docs updates for E/A#96623 scope Time-sensitive alert card qualifier [No QA] Docs updates for E/A#96623 scope Time-sensitive alert card qualifier Aug 18, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://580c5f18.helpdot.pages.dev ⚡️

Updated articles:

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I looked into the failing checks — there's nothing to fix with a code push.

The only check still reporting fail is Check independent approval (failing step "Verify peer review"). That check fails because the PR hasn't received an independent human reviewer's approval yet — it's not caused by anything in this diff, and it clears on its own once someone approves the PR. It's on the list of checks MelvinBot doesn't act on for exactly this reason.

Everything that was pending has since gone green, including the build (Deploy ExpensifyHelp) job — the Jekyll build, redirect/iframe validation, and the [No QA] title check all passed.

Next step: this just needs an independent review + approval. Once you've confirmed the docs change looks right, reply with @MelvinBot mark this PR as ready for review as noted in the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants