Remove allReportActions from Report/index.ts - #98119
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| bankAccountList, | ||
| allReports: allReportsParam, | ||
| sourceReportActions, | ||
| sourceParentReportActions, |
There was a problem hiding this comment.
Decided to migrate mergeReports since it doesn't have any usage yet. They are still preparing.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppscreen-20260817-220825-1786997285371.mp4Android: mWeb ChromeScreen.Recording.2026-08-17.at.20.53.32.moviOS: HybridAppScreen.Recording.2026-08-17.at.20.48.04.moviOS: mWeb SafariScreen.Recording.2026-08-17.at.20.49.09.movMacOS: Chrome / SafariScreen.Recording.2026-08-17.at.20.44.53.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.55-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under Why: This is an internal engineering refactor with no user-facing behavior change:
There are no new features, UI labels, buttons, settings, or copy strings added or changed — the "Message" button flow behaves exactly as before. Nothing in the current help site content documents this internal wiring, so there's nothing to update. No draft PR was created since there are no docs changes to make. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.55-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #73651
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4