Skip to content

[No QA] Remove copy for not yet released functionality from help doc - #97986

Merged
pecanoro merged 1 commit into
mainfrom
nikki-remove-extra=copy
Aug 6, 2026
Merged

[No QA] Remove copy for not yet released functionality from help doc#97986
pecanoro merged 1 commit into
mainfrom
nikki-remove-extra=copy

Conversation

@NikkiWines

Copy link
Copy Markdown
Contributor

Explanation of Change

The "Explain" link is not something we have implemented yet

Fixed Issues

$ N/A noticed when discussing other resource updates

Tests

No QA

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

No QA

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@NikkiWines
NikkiWines requested a review from pecanoro August 6, 2026 14:22
@NikkiWines NikkiWines self-assigned this Aug 6, 2026
@OSBotify

OSBotify commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://fda88351.helpdot.pages.dev ⚡️

Updated articles:

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a single, targeted one-line change to How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md, removing a reference to an Explain link that has not yet been implemented in the product. It removes copy describing not-yet-released functionality, keeping the article accurate to the current UI. This is a scope-appropriate, low-risk edit.

Scores Summary

  • Readability: 10/10 - The revised sentence reads cleanly and remains a well-formed bullet. Removing the trailing clause ("along with an Explain link describing why") leaves a complete, clear sentence with no awkward phrasing.
  • AI Readiness: 10/10 - No impact on structure, headings, or metadata. The change improves AI retrieval accuracy by removing a UI element (Explain) that does not exist, preventing the model from surfacing a non-existent control.
  • Style Compliance: 10/10 - The edit correctly removes a reference to a UI element not present in the product, aligning with the Core UI Referencing Rule (use exact text shown in the product UI; do not invent UI elements). Remaining bold usage (Potential duplicate) is untouched and compliant.

Key Findings

  • The change is precise and matches the PR intent: removing copy for not-yet-released functionality.
  • Removing the phantom Explain link improves accuracy and prevents users (and AI retrieval) from being pointed at a control that does not exist.
  • No structural, heading, metadata, or FAQ changes were introduced, so no governance regressions.
  • Note (pre-existing, outside this diff, not scored): the article uses Title Case section headings such as 'Who Can Use Duplicate Detection' which are not strictly action/question-first per Section 2. These are unchanged by this PR and noted only for future cleanup.

Recommendations

  • No changes required. The diff is correct and ready to merge from a documentation-quality standpoint.
  • Optional future follow-up (unrelated to this PR): normalize section heading casing to Sentence case across the file for consistency.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Find-and-Resolve-Flagged-Duplicate-Expenses.md - Approved. Single-line removal of an unreleased UI reference; fully compliant.

Note: This is a single-line change; no inline comments were necessary.

@pecanoro
pecanoro merged commit 699f082 into main Aug 6, 2026
18 of 19 checks passed
@pecanoro
pecanoro deleted the nikki-remove-extra=copy branch August 6, 2026 15:04
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/pecanoro in version: 9.4.52-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants