ReportActionAvatars -> UserAvatar for multi avatars migration + leftovers

[jmusial]

Explanation of Change

Replaces ReportActionAvatars at every call site where the accounts to render are already known, introducing three lightweight components - AccountAvatars, and AccountAvatarWithCardFeed and using AccountAvatar introduced in previous PR.

They resolve icons from the shared personal-details context via a new useAccountIcons hook instead of subscribing to report and policy Onyx keys. This drops a per-row Onyx subscription from menu items, option rows, selection lists, task previews, and card tables.

This PR also removes the now-unused shouldStackHorizontally and floatRightAvatars props from MenuItem.

Important

May overlap a but with #97961. Not in functionality, but it modifies same files.

Fixed Issues

$ #94586

PROPOSAL:

Tests

Scenario 1 — Selection list avatars, including the workspace subscript

1. Open app.
2. Tap the green + button and select Start chat.
3. Verify that each personal contact row shows that person's avatar, and that hovering it (web) shows the display-name tooltip.
4. Close RHP with chat selector
5. Click Search icon
6. Type the name of your workspace in the search field so the workspace chat row appears in the results.
7. Verify that the workspace chat row shows the workspace avatar as the main avatar with the member avatar as a small subscript in the bottom-right corner.

Scenario 2 — Stacked avatars in the workspace invite flow

1. Open app.
2. Navigate to Settings > Workspaces > [your workspace] > Members.
3. Tap Invite member, select three or more people (mix existing Expensify users with a brand-new email address that has no account yet), then tap Next.
4. Verify that the invite message screen shows a horizontal row of overlapping large avatars, one per invitee, with the not-yet-registered email showing a generated fallback avatar rather than a blank or broken image.
5. Select enough people that the avatars exceed one row, and verify they wrap onto a second row and that any overflow collapses into a "+N" indicator.
6. Go back and deselect everyone so no invitees remain, then reach the invite message screen again.
7. Verify that a single placeholder avatar renders in the same slot.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2026-08-10.at.17.00.42.mov

Android: mWeb Chrome

Screen.Recording.2026-08-10.at.17.13.30.mov

iOS: Native

Screen.Recording.2026-08-10.at.16.55.33.mov

iOS: mWeb Safari

Screen.Recording.2026-08-10.at.16.50.34.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-10.at.16.47.49.mov

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/Avatar/connected/AccountAvatar.tsx	100.00% <100.00%> (ø)
...nts/Avatar/connected/AccountAvatarWithCardFeed.tsx	100.00% <100.00%> (ø)
...components/Avatar/connected/MultiAccountAvatar.tsx	100.00% <100.00%> (ø)
src/components/Avatar/connected/useAccountIcons.ts	100.00% <100.00%> (ø)
...RequestReportView/MoneyRequestViewReportFields.tsx	33.33% <ø> (ø)
...rc/components/ReportActionItem/MoneyReportView.tsx	96.00% <ø> (ø)
...m/TransactionPreview/TransactionPreviewContent.tsx	77.34% <ø> (ø)
...rc/components/ReportActionItem/TripDetailsView.tsx	77.00% <ø> (ø)
...ts/SelectionList/ListItem/InviteMemberListItem.tsx	100.00% <100.00%> (ø)
...nts/SelectionList/ListItem/UserListItemContent.tsx	100.00% <100.00%> (ø)
... and 12 more
... and 3 files with indirect coverage changes

[jmusial]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 4e324b8cf7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[melvin-bot]

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[jmusial]

cc. @roryabraham AccountAvatar PR 2

[trjExpensify]

PR doesn’t need product input as a perf PR. Unassigning and unsubscribing myself.

[roryabraham]

@sobitneupane this is awaiting C+ review and checklist

[sobitneupane]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-08-13.at.13.26.02.mov

Screen.Recording.2026-08-13.at.13.28.13.mov

Android: mWeb Chrome

Screen.Recording.2026-08-13.at.13.32.03.mov

iOS: HybridApp

Screen.Recording.2026-08-13.at.13.43.47.mov

iOS: mWeb Safari

Screen.Recording.2026-08-13.at.13.46.34.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-13.at.13.07.33.mov

[roryabraham]

Darn @jmusial, there are conflicts here. But GitHub doesn't actually show me which files have conflicts 😕

[jmusial]

@roryabraham this is ready for you

[github-actions]

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97983.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c19e324-ea2b689-6e5c76b542fd1ec20903fafbfb4805d2d088ea43/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c19e324-ea2b689-ce21a4d67533206e542671fb5416063f558a25d9/index.html

Web 🕸️
https://97983.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.56-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 I reviewed the changes in this PR against Expensify's help site content under docs/articles.

No help site changes are required.

This PR is a purely internal, non-user-facing refactor of how avatars are rendered:

• Replaces ReportActionAvatars with lightweight components (AccountAvatars, AccountAvatarWithCardFeed, AccountAvatar) at call sites where the accounts are already known.
• Resolves icons from the shared personal-details context via a new useAccountIcons hook instead of per-row report/policy Onyx subscriptions (a performance optimization).
• Removes the now-unused shouldStackHorizontally and floatRightAvatars props from MenuItem.

None of this changes visible product behavior, feature names, settings labels, tabs, buttons, or workflows. The help articles describe what users can do and configure — not internal component architecture or rendering plumbing — so there is nothing to document or update here.

Because no documentation change is needed, I did not create a draft help site PR.