[Part 25] Remove Onyx.connect from LocalePhoneNumber

[marufsharifi]

Explanation of Change

This change removes the direct @libs/LocalePhoneNumber formatter dependency from the money-request optimistic data builder. MoneyRequestBuilder now requires formatPhoneNumber through its money-request params and uses that injected formatter when creating optimistic personal details for new money-request chats.

The formatter is threaded through the existing localized money-request flows, including request money, duplicate, per diem, split, split transaction updates, track expense conversion, add existing expense, delete transactions, and share submit details. Tests and fixtures were updated to pass the shared test formatter, and a focused regression assertion verifies that a new-chat optimistic personal detail display name is formatted through the injected function.

Fixed Issues

$ #66327
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

1. Log in to New Expensify.
2. From the global create button, choose to submit/request money.
3. Choose a manual money request.
4. Enter any amount, for example $10.00.
5. Continue to the participant/recipient step.
6. Enter a phone number recipient that is not already in your contacts or existing chats.
7. Select that phone number recipient.
8. Continue to the confirmation step.
9. Submit the money request.
10. Verify a new one-on-one money request chat is created.
11. Verify the participant name shown in the new chat/report header is a formatted phone number, not a raw phone string.
12. Verify the money request preview/action appears correctly with the expected amount.
13. Refresh the app or reopen the chat.
14. Verify the chat still loads correctly, and the participant display remains formatted.
15. Repeat the same manual request flow with an existing email/contact recipient.
16. Verify the request still submits successfully and existing contact display names are unchanged.

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screencast.From.2026-08-03.16-23-46.webm

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useDeleteTransactions.ts	60.00% <100.00%> (+0.27%)	⬆️
src/libs/IOUAmountSubmission.ts	86.70% <ø> (ø)
src/libs/actions/IOU/Duplicate.ts	91.94% <ø> (ø)
src/libs/actions/IOU/MoneyRequest.ts	74.66% <ø> (ø)
src/libs/actions/IOU/MoneyRequestBuilder.ts	90.23% <ø> (ø)
src/libs/actions/IOU/Split.ts	72.17% <ø> (ø)
src/libs/actions/IOU/SplitTransactionUpdate.ts	91.14% <ø> (ø)
src/libs/actions/IOU/TrackExpense.ts	84.57% <ø> (+0.15%)	⬆️
src/pages/Share/SubmitDetailsPage.tsx	90.23% <100.00%> (ø)
...rc/pages/iou/request/step/IOURequestStepAmount.tsx	90.67% <100.00%> (ø)
... and 4 more
... and 9 files with indirect coverage changes

[melvin-bot]

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[JmillsExpensify]

No product review required.

[marufsharifi]

@shubham1206agra, could you please take a look at this pr when you get a chance? thanks.

the failure actions are not related to our changes. BTW

[shubham1206agra]

@marufsharifi Please fix the errors

[marufsharifi]

@shubham1206agra, fixed. could you please take another look. thanks.

[marufsharifi]

@shubham1206agra, Gentle bump. thanks.

[shubham1206agra]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-08.at.12.00.54.AM.mov

[mountiny]

@marufsharifi can you please fix the spell check

[marufsharifi]

@mountiny, that doesn't seems to be related to our changes. thanks.

[mountiny]

@marufsharifi it is not failing on main, can you sync with main then? thanks

[marufsharifi]

@mountiny, it also fail locally on the latest main. I don’t think it’s related to the changes in this PR, though. Thanks!

[marufsharifi]

@mountiny, I’ve addressed your suggestions, and all actions are now passing. When you get a chance, could you please take another look? Thanks!

[mountiny]

Thanks!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97680.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-22116f7cd59-0e2bf42-1a91278386410ab24460a79cb70a771122afafd2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-22116f7-0e2bf42-66f34cc8a3b806b11caf1605c186aa5b90fb44df/index.html

Web 🕸️
https://97680.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.53-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 I reviewed the changes in this PR and no help site changes are required.

This is a purely internal refactor: it removes the direct @libs/LocalePhoneNumber formatter dependency from the money-request optimistic data builder and threads formatPhoneNumber through the money-request flows (request money, duplicate, per diem, split, track expense, etc.) as an injected function.

There is no user-facing behavior change — phone-number recipients are still formatted the same way in new-chat optimistic personal details. The PR adds no new features, settings, tabs, buttons, or UI copy, so there is nothing to document or update under App/docs/articles.

Because no documentation update is needed, I did not create a draft help site PR.

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.53-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android