Move selected distance rate to the top of the rate list - #97631
Open
marufsharifi wants to merge 10 commits into
Open
Move selected distance rate to the top of the rate list#97631marufsharifi wants to merge 10 commits into
marufsharifi wants to merge 10 commits into
Conversation
…k and improve type assertions
marufsharifi
marked this pull request as ready for review
August 17, 2026 09:32
melvin-bot
Bot
requested review from
heyjennahay and
linhvovan29546
and removed request for
a team and
heyjennahay
August 17, 2026 09:32
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| } as unknown as Transaction; | ||
|
|
||
| function renderPage() { | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- test-only route stub; the page only reads route.params |
Contributor
There was a problem hiding this comment.
❌ CONSISTENCY-16 (docs)
The justification in this eslint-disable comment joins two independent clauses with a semicolon (test-only route stub; the page only reads route.params). Comments should read as plain sentences rather than semicolon-joined clauses.
Split it into two sentences, e.g.:
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- test-only route stub. The page only reads route.paramsReviewed at: da11f18 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
Contributor
Author
|
@linhvovan29546 The PR is ready for review, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes the distance rate picker so the currently-selected rate is shown at the top of the list when the picker opens, matching the "pre-selected items to the top" behavior we've rolled out across the app (country, category, tax rate, etc.).
Fixed Issues
$ #69184
PROPOSAL: #69184 (comment)
Tests
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-03.at.10.25.59.AM.mov
Android: mWeb Chrome
Screen_Recording_20260803_102326_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-03.at.10.43.05.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-03.at.10.44.40.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-03.at.10.14.13.AM.mov