Skip to content

Move selected distance rate to the top of the rate list - #97631

Open
marufsharifi wants to merge 10 commits into
Expensify:mainfrom
marufsharifi:fix/distance-rate-selected-order
Open

Move selected distance rate to the top of the rate list#97631
marufsharifi wants to merge 10 commits into
Expensify:mainfrom
marufsharifi:fix/distance-rate-selected-order

Conversation

@marufsharifi

@marufsharifi marufsharifi commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixes the distance rate picker so the currently-selected rate is shown at the top of the list when the picker opens, matching the "pre-selected items to the top" behavior we've rolled out across the app (country, category, tax rate, etc.).

Fixed Issues

$ #69184
PROPOSAL: #69184 (comment)

Tests

  1. Open a Control or Collect workspace → More features → enable Distance rates.
  2. Under Distance rates, add rates until there are at least 12 enabled rates. Give them names so the currently-selected one is not first alphabetically (e.g. many "A…" rates plus one "Zebra rate").
  3. Start a distance expense on that workspace (Submit expense → Distance) and proceed to the confirmation page.
  4. Tap the Rate field to open the rate picker.
  5. Verify: the currently-selected rate appears at the top of the list
  6. Pick a different rate → it saves and the picker closes. Re-open the Rate picker.
  7. Verify: the newly-selected rate is now pinned at the top.
  • Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-03.at.10.25.59.AM.mov
Android: mWeb Chrome
Screen_Recording_20260803_102326_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-03.at.10.43.05.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-03.at.10.44.40.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-03.at.10.14.13.AM.mov

@marufsharifi
marufsharifi marked this pull request as ready for review August 17, 2026 09:32
@marufsharifi
marufsharifi requested review from a team as code owners August 17, 2026 09:32
@melvin-bot
melvin-bot Bot requested review from heyjennahay and linhvovan29546 and removed request for a team and heyjennahay August 17, 2026 09:32
@melvin-bot

melvin-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 17, 2026 09:32
} as unknown as Transaction;

function renderPage() {
// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- test-only route stub; the page only reads route.params

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CONSISTENCY-16 (docs)

The justification in this eslint-disable comment joins two independent clauses with a semicolon (test-only route stub; the page only reads route.params). Comments should read as plain sentences rather than semicolon-joined clauses.

Split it into two sentences, e.g.:

// eslint-disable-next-line @typescript-eslint/no-unsafe-type-assertion -- test-only route stub. The page only reads route.params

Reviewed at: da11f18 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

@marufsharifi

Copy link
Copy Markdown
Contributor Author

@linhvovan29546 The PR is ready for review, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant