[No QA] Docs updates for E/A#96981 Document RuleBot removal guard for Agent rules - #97390
Conversation
…exist Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>
HelpDot Documentation ReviewOverall Assessment This PR adds documentation for the RuleBot removal guard (follow-up to E/A 96981). The changes add one How to remove RuleBot from a workspace section and one FAQ entry to Create-Agent-Rules.md, explaining that RuleBot cannot be removed, demoted, or deleted while a workspace still has Agent rules, and how to resolve it. The additions are focused, accurate, and well-aligned with the existing article single-workflow scope. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a top-level summary review. |
|
@MelvinBot adjust the two open threads |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af070ed05d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…link for delete section
Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
Both open review threads are addressed in cb57ee9:
I replied inline on each thread as well. The separate Codex thread about documenting non-admin role changes was left untouched since your request was scoped to the two open review threads — let me know if you'd like that one adjusted too. |
|
Approved! Will merge tomorrow once this hits production. |
f36eb9e
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot resolve conflicts, @VictoriaExpensify and @stephanieelliott are we missing something? |
Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com> # Conflicts: # docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md
|
✅ Conflicts resolved in The only conflict was in
|
|
A preview of your ExpensifyHelp changes have been deployed to https://5d6b34d9.helpdot.pages.dev ⚡️ Updated articles: |
|
I looked into the failing check — there's nothing to fix here. 👍 The only check reporting Everything else that has run is passing ( Next step: get an independent review/approval on the PR and the |
|
The only failing check is Check independent approval, and there's nothing to fix in the code — every real CI check (
Since this PR is still a Melvin-authored draft awaiting your review, the next step is on you: review the doc changes, and if they look right, comment |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.55-0 🚀
|
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.55-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Follow-up to #96981, which prevents removing, demoting, or deleting RuleBot while a workspace still has Agent rules. This documents that new user-facing behavior in the help site.
What changed
Updated
docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md:Why
The article previously stated RuleBot is "managed by Expensify" but did not explain that admins are now blocked from removing/demoting/deleting RuleBot while Agent rules exist, or how to resolve it (delete all Agent rules first). This closes that gap.
Related
@NicolasBonet, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.