[No QA] Docs updates for E/A#90002 Document GPS Edit stop trimming feature - #97379
[No QA] Docs updates for E/A#90002 Document GPS Edit stop trimming feature#97379MelvinBot wants to merge 2 commits into
Conversation
Co-authored-by: Gabriel Cyganek <GCyganek@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR documents the new Edit stop trimming capability in the GPS Distance expense flow (from #90002). The proposed diff is small and focused: one new FAQ entry ( Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
There's nothing to fix here — no code or test check is failing. The only red check is Check independent approval, and it's not a code failure. It fails because this PR doesn't have any independent Expensify employee approval yet: That check simply gates merge on a human review — it will pass on its own once a reviewer approves. Every real CI check ( So no push is needed. To move this forward, get an independent Expensify employee to review and approve the PR. |
|
A preview of your ExpensifyHelp changes have been deployed to https://252d02b2.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @zanyrenney |
|
@zanyrenney Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Still nothing to fix by pushing code — every real CI check now passes. The previously-pending checks have all gone green ( The only red check is Check independent approval, which is not a code failure: It's a merge gate that clears on its own once an independent Expensify employee reviews and approves the PR. To move this forward, get a reviewer's approval — there's no code change I can push to make it pass. |
|
Still nothing to fix by pushing code — every real check is now green ( The only red check is Check independent approval, which is not a code failure. It's a merge gate reporting that the PR has no independent Expensify employee approval yet: It will clear on its own once an independent Expensify employee reviews and approves the PR. To unblock, get that review — there's no fix for me to push. |
Explanation of Change
Documents the new Edit stop feature added to the GPS Distance expense flow in #90002.
After a user taps Stop on a GPS trip, a pencil Edit icon now appears next to the distance counter. Tapping it opens the Edit stop screen, where the user drags a slider to trim the trip back to an earlier stop point along the recorded route. The map route and Total distance update live, and tapping Save returns to the GPS screen with the trimmed distance and updated end address.
Changes to
docs/articles/new-expensify/reports-and-expenses/Distance-Expenses.mdkeywordswith the new feature terms (edit stop, trim trip, edit GPS trip, etc.).All UI labels (Edit, Edit stop, Total distance, Save, Resume, Stop) were verified against the strings added in the source PR (
src/languages/en.tsandIOURequestStepGPSTripEdit) and follow the HELPSITE_NAMING_CONVENTIONS and HELP_AUTHORING_GUIDELINES (Sentence case, bold UI elements, task-based headings).Related PR
@GCyganek, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.