refactor getReportPreviewMessage and getIOUReportActionDisplayMessage to use data from useOnyx by daledah · Pull Request #96906 · Expensify/App

daledah · 2026-07-23T20:32:42Z

Explanation of Change

Fixed Issues

$ #66415
PROPOSAL:

Tests

Open a workspace chat and submit an expense
As the approver, approve that expense report.
Verify: in the report, the action line shows the correct message approved
Right-click (or long-press on mobile) that same action → copy to clipboard, then paste it somewhere.
Verify: the copied text matches the message shown on screen (approved).

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-24.at.03.45.06.mov

… to use data from useOnyx

codecov · 2026-07-23T20:41:26Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/OptionsListUtils/index.ts	`87.31% <ø> (ø)`
src/libs/PaymentUtils.ts	`89.89% <100.00%> (ø)`
...x/report/actionContents/IouReportActionMessage.tsx	`100.00% <100.00%> (ø)`
...ges/inbox/report/actionContents/PaymentContent.tsx	`100.00% <100.00%> (ø)`
src/selectors/Policy.ts	`77.94% <100.00%> (+0.16%)`	⬆️
src/libs/ReportUtils.ts	`87.36% <80.00%> (+0.20%)`	⬆️
...es/inbox/report/ContextMenu/ContextMenuActions.tsx	`40.60% <0.00%> (ø)`
... and 9 files with indirect coverage changes

melvin-bot · 2026-07-23T20:45:54Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

No product review required.

DylanDylann · 2026-08-03T08:06:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2d7890e90

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

daledah · 2026-08-04T10:02:04Z

@DylanDylann i updated

DylanDylann · 2026-08-05T07:42:25Z


    if (isSentMoneyReportAction(reportAction)) {
-        return getIOUReportActionDisplayMessage(translate, reportAction as ReportAction, convertToDisplayString, linkedTransaction);
+        return getIOUReportActionDisplayMessage(translate, reportAction as ReportAction, convertToDisplayString, undefined, linkedTransaction);


Why do you pass undefined here?

@DylanDylann In the old code the policy was resolved from allPolicies using report?.policyID, where report is a parameter of getIOUReportActionDisplayMessage itself - and this call site never passed it . So reportPolicy was already always undefined on this path and the last-4-digits fallback always returned ''.

DylanDylann · 2026-08-05T07:44:15Z

@daledah Please avoid passing a big object when we only use part of the data. In this case, passing policy looks redundant in some cases, bcz we only use olicy?.achAccount?.accountNumber. Let's minimize them

daledah · 2026-08-06T15:54:49Z

@daledah Please avoid passing a big object when we only use part of the data. In this case, passing policy looks redundant in some cases, bcz we only use olicy?.achAccount?.accountNumber. Let's minimize them

i updated getIOUReportActionDisplayMessage and getBankAccountLastFourDigits, they now take policyACHAccountNumber: string | undefined instead of the whole policy.

The remaining policy param is in getReportPreviewMessage, which was already there before this PR and uses more than just the ACH number getPolicyName({policy}), policy?.type for isGroupPolicyByType, and policy?.achAccount?.accountNumber

DylanDylann · 2026-08-11T07:55:38Z

@daledah Please resolve conflict

DylanDylann · 2026-08-11T07:55:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-11.at.14.56.09.mov

DylanDylann · 2026-08-11T07:56:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b684cca59

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-08-11T08:17:24Z

@MelvinBot Could you verify this comment?? I think both policy and policy for the linked iouReport.policyID are identical

daledah · 2026-08-12T07:57:35Z

@DylanDylann i addressed all comments, please check again

DylanDylann · 2026-08-18T07:21:17Z

@codex review

chatgpt-codex-connector · 2026-08-18T07:24:40Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 87ba066b1a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-08-18T07:42:10Z

@daledah Failed typecheck

refactor getReportPreviewMessage and getIOUReportActionDisplayMessage…

79f79a3

… to use data from useOnyx

melvin-bot Bot assigned daledah Jul 23, 2026

add new test case

b65ac69

daledah marked this pull request as ready for review July 23, 2026 20:45

daledah requested review from a team as code owners July 23, 2026 20:45

melvin-bot Bot requested a review from DylanDylann July 23, 2026 20:45

melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 23, 2026 20:45

daledah mentioned this pull request Jul 23, 2026

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.POLICY in src/libs/ReportUtils.ts #66415

Open

JmillsExpensify reviewed Jul 25, 2026

View reviewed changes

daledah added 2 commits August 3, 2026 12:03

resolve conflict

dbf2bf3

fix jest test

b2d7890

DylanDylann reviewed Aug 3, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts

Comment thread src/libs/ReportUtils.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread src/libs/OptionsListUtils/index.ts

daledah added 3 commits August 4, 2026 15:06

resolve conflict

f995094

fix ts

62169fd

update to require policy param

7fa9cea

DylanDylann reviewed Aug 5, 2026

View reviewed changes

daledah added 3 commits August 6, 2026 18:08

resolve conflict

d757a94

apply selector

a1a8160

Merge branch 'main' into refactor/66415-6

0b684cc

DylanDylann reviewed Aug 11, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Comment thread src/libs/OptionsListUtils/index.ts

daledah added 2 commits August 12, 2026 14:41

resolve conflict

2dd308d

address comment

7ab92b5

DylanDylann reviewed Aug 12, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts

Merge branch 'main' into refactor/66415-6

87ba066

DylanDylann approved these changes Aug 18, 2026

View reviewed changes

daledah added 2 commits August 18, 2026 14:34

Merge branch 'main' into refactor/66415-6

07d30d1

add comment

af2ae81

fix ts

d55156a

DylanDylann approved these changes Aug 18, 2026

View reviewed changes

melvin-bot Bot requested a review from lakchote August 18, 2026 08:49

Uh oh!

Conversation

daledah commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 23, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 23, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented Aug 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

daledah commented Aug 4, 2026

Uh oh!

DylanDylann Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

daledah Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daledah commented Aug 6, 2026

Uh oh!

Uh oh!

DylanDylann commented Aug 11, 2026

Uh oh!

DylanDylann commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Aug 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

DylanDylann commented Aug 11, 2026

Uh oh!

daledah commented Aug 12, 2026

Uh oh!

Uh oh!

DylanDylann commented Aug 18, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 18, 2026

Uh oh!

DylanDylann commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

daledah commented Jul 23, 2026 •

edited

Loading

codecov Bot commented Jul 23, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Aug 5, 2026 •

edited

Loading

DylanDylann commented Aug 11, 2026 •

edited

Loading