Skip to content

fix: Bump react-native-pager-view to 9.0.2 - #96621

Open
TaduJR wants to merge 5 commits into
Expensify:mainfrom
TaduJR:fix-Android-Split-Percentage-input-has-to-be-focused-twice-to-be-able-to-edit-it
Open

fix: Bump react-native-pager-view to 9.0.2#96621
TaduJR wants to merge 5 commits into
Expensify:mainfrom
TaduJR:fix-Android-Split-Percentage-input-has-to-be-focused-twice-to-be-able-to-edit-it

Conversation

@TaduJR

@TaduJR TaduJR commented Jul 21, 2026 •
edited by mountiny
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #78089
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14061

Tests

  1. Open a workspace chat and create a manual expense.
  2. Open the just-created expense and tap More > Split.
  3. Tap the Percent tab.
  4. Tap the percentage input of any split.
  5. Verify the input is focused on the first tap, the keyboard opens, and the input stays focused (it must not lose focus right after tapping).
  6. Type a new percentage and verify you can edit it right away.
  7. Switch to the Amount tab, tap an amount input, and verify it also focuses on the first tap.
  8. Switch between Amount and Percent a few times and verify the highlighted tab and the list content always match.
  9. Open the Date tab and verify it displays correctly.

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android-Native.mp4
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@TaduJR
TaduJR requested a review from a team as a code owner July 21, 2026 10:51
@melvin-bot
melvin-bot Bot requested a review from brunovjk July 21, 2026 10:51
@melvin-bot

melvin-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 21, 2026 10:51
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@TaduJR
TaduJR marked this pull request as draft July 21, 2026 10:52
@TaduJR

TaduJR commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

cc @adhorodyski @carlosmiceli

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 21, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12c67ffb46

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread package.json Outdated
@brunovjk

brunovjk commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@TaduJR I noticed two potential blockers and wanted to confirm my understanding:

  1. Since this PR updates only App/ios/Podfile.lock, could HybridApp restore its pods using Mobile-Expensify/iOS/Podfile.lock and end up running react-native-pager-view@9.0.0-rc.1 in JS with the previous native pod version?

Do we also need to update the Mobile-Expensify lockfile/submodule or invalidate its Pods cache?

  1. The updated ios/Podfile.lock also removes some React-rendererconsistency dependencies and changes checksums for packages such as boost, hermes-engine, React-Core, and React-perflogger.

These changes don’t seem directly related to the pager-view upgrade. Were they expected, or should the lockfile be regenerated from a clean base? Thank you.

TaduJR added 2 commits July 23, 2026 15:20
@TaduJR
Merge branch 'main' of https://github.com/TaduJR/App into fix-Android…
229e07d 
…-Split-Percentage-input-has-to-be-focused-twice-to-be-able-to-edit-it

# Conflicts:
#	package-lock.json
#	package.json
@TaduJR
Merge branch 'main' of https://github.com/TaduJR/App into fix-Android…
899989e 
…-Split-Percentage-input-has-to-be-focused-twice-to-be-able-to-edit-it

# Conflicts:
#	package.json
@TaduJR

TaduJR commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @brunovjk

  1. HybridApp iOS restores pods from Mobile-Expensify/ios/Podfile.lock, so it would run rc.1 JS against the 8.0.0 pod. A companion Mobile-Expensify PR updating its lockfile is needed, since that repo is private and I don't have access, could you or @carlosmiceli handle that side?

  2. I've reset the branch onto latest main and regenerated from a clean base

@brunovjk

brunovjk commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks @TaduJR for the hard work! The Podfile.lock looks good now. Let’s wait for Carlos about the Mobile-Expensify side.

@adhorodyski

adhorodyski commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Thanks! Since this tests fine, I contacted the maintainer and a stable version is going to be released so you can bump this PR soon. I'll let you know once it's ready 👍🏼

@TaduJR

TaduJR commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @adhorodyski @brunovjk

@TaduJR TaduJR changed the title fix: Bump react-native-pager-view to 9.0.0-rc.1 fix: Bump react-native-pager-view to 9.0.2 Aug 15, 2026
@TaduJR
Merge branch 'main' of https://github.com/TaduJR/App into fix-Android…
7b84142 
…-Split-Percentage-input-has-to-be-focused-twice-to-be-able-to-edit-it

# Conflicts:
#	package-lock.json
#	package.json
@TaduJR
TaduJR marked this pull request as ready for review August 15, 2026 15:33
@mountiny

mountiny commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@TaduJR @brunovjk created the PR here https://github.com/Expensify/Mobile-Expensify/pull/14061

CAn you please resolve the conflicts and move this ahead? thanks

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96621 Mobile-Expensify PR Expensify/Mobile-Expensify#14061.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7b84142-71918eefcd-2251c5c113d5f447c7fa4c7c153a6ddf2ef3758a/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7b84142-71918eefcd-8634bad27b6f6c9d85d63ef9e6f8719954da8797/index.html
Android iOS
Web 🕸️
https://96621.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@TaduJR
Merge branch 'main' of https://github.com/TaduJR/App into fix-Android…
296fdb5 
…-Split-Percentage-input-has-to-be-focused-twice-to-be-able-to-edit-it

# Conflicts:
#	package-lock.json
#	package.json
@TaduJR

TaduJR commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@TaduJR

TaduJR commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Done @mountiny

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 296fdb5a7b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@brunovjk brunovjk Awaiting requested review from brunovjk

At least 1 approving review is required to merge this pull request.

Assignees

@TaduJR TaduJR

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TaduJR @brunovjk @adhorodyski @mountiny