Fix - Merge expenses prompts for attendee selection even when both expenses have the same attendee - #96526
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 946d54055d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@FitseTLT Could you please merge main? |
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2026-07-25.at.21.34.35.mov
Android: mWeb Chrome
Screen.Recording.2026-07-25.at.21.36.40.mov
iOS: HybridApp
Screen.Recording.2026-07-25.at.21.51.33.mov
iOS: mWeb Safari
Screen.Recording.2026-07-25.at.21.43.53.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-25.at.21.11.46.mov
Screen.Recording.2026-07-25.at.21.15.31.mov
Screen.Recording.2026-07-25.at.21.16.45.mov
|
@FitseTLT conflicts |
e578070
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.52-0 🚀
|
|
🤖 Help site review: no docs changes required. This PR is a bug fix to the merge-expenses conflict detector — it stops the "Select the details you want to keep" step from prompting for an attendee when both expenses already resolve to the same attendee (by removing the optimistic default-attendee stamp and applying the report-owner fallback during conflict detection). It doesn't add features, rename anything, or change any user-facing labels, settings, or workflow. The relevant help article, How to Merge Duplicate Expenses, already describes the corrected behavior — including this FAQ, which matches this fix exactly:
I also checked Adding Attendees and searched the docs — nothing documents an automatic/default attendee on expense creation, so removing the optimistic stamp doesn't contradict any published article. Since this brings the app in line with what the docs already say, no draft PR was created. @FitseTLT, please confirm you agree no help site changes are needed. If you think an article should be updated (e.g. added detail about attendees during merge), reply with |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
When merging two expenses that have the same attendee, the merge flow wrongly prompted the user to pick an attendee. Two things caused it:
comment.attendees = [you]), even though the backend only persists attendees the user explicitly selects. So two otherwise-identical expenses could hold[you]in optimistic Onyx while the synced value was empty — a phantom difference.getMergeableDataAndConflictFields) compared attendees without applying the report-owner fallback that the display path (buildMergeFieldsData) uses. So an empty attendee list compared as[]instead of[owner], producing a false conflict against an expense whose attendee resolves to that same owner.This PR:
initMoneyRequest(MoneyRequest.ts) andbuildOptimisticTransactionAndCreateDraft(TransactionEdit.ts), so optimistic data matches the backend. Display is unchanged becausegetAttendeesstill falls back to the report owner when the stored list is empty.getMergeableDataAndConflictFieldsand applies it at every merge entry point — the details page, the receipt-review page, and the direct/bulk merge action — so attendee conflict detection matches what the UI displays and stops flagging identical attendees.Fixed Issues
$ #94700
PROPOSAL: #94700 (comment)
Tests
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2026-07-21.16-24-58.mp4
Android: mWeb Chrome
2026-07-21.00-03-22.mp4
iOS: Native
iOS: mWeb Safari
2026-07-21.00-05-18.mp4
MacOS: Chrome / Safari
2026-07-20.23-59-48.mp4