ReportActionAvatars -> UserAvatar for single avatars migration by jmusial · Pull Request #94906 · Expensify/App

jmusial · 2026-06-29T20:49:25Z

Explanation of Change

This PR adds Avatar/connected/AccountAvatar - a single-accountID avatar that resolves its icon from the personal-details context through a shared buildUserIcon helper, with none of ReportActionAvatars' Onyx subscriptions, report/action/policy lookups, or layout resolution - and migrates the eight call sites that were using ReportActionAvatars to render exactly one known user.

No visual change is intended.

Fixed Issues

$ #94586
PROPOSAL:

Tests

Open app
Navigate to workspace that has members with custom and default avatars.
Verify that avatars display.
On web: verify that tooltip shows once avatar is hovered
Open concierge chat
Verify that Conceirge shows correct avatar, and hover on web works same as in 4.
Navigate to Account -> Agents, and make sure you have some agents configured.
Verify that Agents show correct avatars, and hover on web works same as in 4.

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-08-05.at.12.28.21.mov

Android: mWeb Chrome

Screen.Recording.2026-08-05.at.12.24.14.mov

iOS: Native

Screen.Recording.2026-08-05.at.12.44.42.mov

iOS: mWeb Safari

Screen.Recording.2026-08-05.at.12.31.45.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-05.at.12.11.07.mov

jmusial · 2026-06-29T21:01:31Z

@codex review

codecov · 2026-06-29T21:03:40Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Avatar/connected/AccountAvatar.tsx	`100.00% <100.00%> (ø)`
src/components/Avatar/layouts/SingleAvatar.tsx	`100.00% <ø> (ø)`
src/components/ReportActionAvatars/index.tsx	`96.36% <ø> (-0.07%)`	⬇️
...ents/ReportActionAvatars/useReportActionAvatars.ts	`88.09% <100.00%> (-0.21%)`	⬇️
...c/components/Tables/AgentsTable/AgentsTableRow.tsx	`100.00% <ø> (ø)`
.../Tables/DomainAdminsTable/DomainAdminsTableRow.tsx	`0.00% <ø> (ø)`
...ables/DomainMembersTable/DomainMembersTableRow.tsx	`0.00% <ø> (ø)`
...rtParticipantsTable/ReportParticipantsTableRow.tsx	`0.00% <ø> (ø)`
...ts/Tables/RoomMembersTable/RoomMembersTableRow.tsx	`0.00% <ø> (ø)`
...WorkspaceMembersTable/WorkspaceMembersTableRow.tsx	`91.30% <ø> (-1.01%)`	⬇️
... and 4 more
... and 14 files with indirect coverage changes

chatgpt-codex-connector · 2026-06-29T21:11:50Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 540e4b09e3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…' into chore/user-avatar-for-single-avatar-usages

jmusial · 2026-08-05T09:40:22Z

@codex review

chatgpt-codex-connector · 2026-08-05T09:50:26Z

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: dc3daaa7c1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-08-05T10:45:43Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jmusial · 2026-08-05T10:57:02Z

cc @roryabraham

roryabraham

No blockers from me. This PR feels like a nice step in the right direction. If we don't include the new tests, it's a net reduction in code. Great job!

roryabraham · 2026-08-05T20:02:44Z

Just clarifying, I think the intention is that src/Avatar/connected contains the level-two wrappers around the level-one primitives for common use-cases. And they're "connected" because they actually hook up data, rather than just displaying what they're given via props?

yup, that was my reasoning behind the name. Open to other suggestions if you feel like naming should be highlighting leveled structure more

roryabraham · 2026-08-05T20:04:35Z

+    size?: ValueOf<typeof CONST.AVATAR_SIZE>;
+
+    /** Whether to show the tooltip on hover */
+    shouldShowTooltip?: boolean;


I think it's been an oversight of our efforts so far that shouldShowTooltip has survived our decomposition efforts. Callsites that use tooltips should include them in the JSX themselves. Callsites that don't should not.

NAB for this PR, but I think it's something we should address separately

Agreed, but I'd rather do it in separate PR -> Draft stacked on this one

@jmusial Use GH stack PRs system they recently introduced.

would love to but AFAIK they don't work from forks :(

roryabraham · 2026-08-05T20:09:30Z

awaiting C+ review

joekaufmanexpensify · 2026-08-05T20:11:38Z

No product review needed.

jmusial · 2026-08-06T12:33:25Z

There will be a second PR for this issue - migrating for multiple accounts passed

jmusial · 2026-08-07T08:01:42Z

@shubham1206agra kind bump

shubham1206agra · 2026-08-07T11:46:53Z

+ * Use whenever exactly one account is rendered. Pass `Avatar/UserAvatar` a `source` instead when the avatar is already resolved.
+ */
+function AccountAvatar({accountID, size = CONST.AVATAR_SIZE.DEFAULT, shouldShowTooltip = true, fallbackDisplayName, containerStyle}: AccountAvatarProps) {
+    const personalDetails = usePersonalDetails();


@jmusial Do we need to subscribe to entire personal details object for a single one? Maybe use personalDetailsSelector selector for this. Since personal details object is not super deep, I would say this would optimize the component.

@shubham1206agra usePersonalDetails uses context underneath so I think this should be cheaper that creating new useOnyx subscription for every avatar

shubham1206agra · 2026-08-07T15:13:58Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-07.at.8.42.23.PM.mov

OSBotify · 2026-08-07T20:27:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-07T21:22:50Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-08-07T21:30:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94906.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5f18a9adc9f-7e8bfd0-a5a8bda8bb2b72f67f33fe548ed16d975f9cf223/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5f18a9a-7e8bfd0-3077419cfa767886df1d63bcc1ff29089b823598/index.html

Web 🕸️
https://94906.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-10T22:05:51Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-08-10T22:08:20Z

🤖 I reviewed this PR against Expensify's help site content under docs/articles, and no help site changes are required.

Why: This is an internal component refactor. It adds Avatar/connected/AccountAvatar and migrates eight call sites from ReportActionAvatars to render single-user avatars, with "No visual change intended." All 22 changed files are components, utilities, and tests — there are no changes to user-facing features, workflows, settings, navigation, or UI copy (verified: the only text-adjacent diffs are code comments and test descriptions). The help site documents product behavior for customers, so a change that leaves behavior identical has nothing to document.

No draft PR was created since there's nothing to update.

OSBotify · 2026-08-12T18:15:46Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Create UserAvatar

f87c022

melvin-bot Bot assigned jmusial Jun 29, 2026

fix concierge is thinkging tests

540e4b0

jmusial added 9 commits June 30, 2026 15:19

Merge branch 'main' into chore/user-avatar-for-single-avatar-usages

41e29ac

Merge branch 'main' into chore/user-avatar-for-single-avatar-usages

9f6f6a9

Merge remote-tracking branch 'origin/chore/refactor-avatar-primitives…

84fc1a8

…' into chore/user-avatar-for-single-avatar-usages

Move UserAvatar to /Avatar

30a84c8

remove dead prop

fbb170e

Self review fixes

735390f

Rename connected/UsersAvatar to AccountAvatar

f8904b2

simplify buildUserIcon

5342cf3

Merge branch 'main' into chore/user-avatar-for-single-avatar-usages

dc3daaa

jmusial marked this pull request as ready for review August 5, 2026 10:45

jmusial requested review from a team as code owners August 5, 2026 10:45

melvin-bot Bot requested review from joekaufmanexpensify and shubham1206agra and removed request for a team August 5, 2026 10:45

roryabraham previously approved these changes Aug 5, 2026

View reviewed changes

joekaufmanexpensify removed their request for review August 5, 2026 20:11

Merge branch 'main' into chore/user-avatar-for-single-avatar-usages

92d2816

jmusial dismissed roryabraham’s stale review via 92d2816 August 7, 2026 09:23

shubham1206agra reviewed Aug 7, 2026

View reviewed changes

shubham1206agra approved these changes Aug 7, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham August 7, 2026 15:14

roryabraham approved these changes Aug 7, 2026

View reviewed changes

roryabraham merged commit 5f18a9a into Expensify:main Aug 7, 2026
36 of 45 checks passed

OSBotify mentioned this pull request Aug 10, 2026

Deploy Checklist: New Expensify 2026-08-10 #98179

Closed

quinthar added the #quality label Aug 11, 2026

MelvinBot mentioned this pull request Aug 12, 2026

[Tracking] Decompose ReportActionAvatars into layered avatar components #94584

Open

melvin-bot Bot mentioned this pull request Aug 12, 2026

[Due for payment 2026-08-21] [Performance] ReportActionAvatars — UsersAvatar + accountIDs migration #94586

Open

Uh oh!

Conversation

jmusial commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial commented Jun 29, 2026

Uh oh!

codecov Bot commented Jun 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot commented Jun 29, 2026

Uh oh!

jmusial commented Aug 5, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 5, 2026

Uh oh!

melvin-bot Bot commented Aug 5, 2026

Uh oh!

jmusial commented Aug 5, 2026

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

roryabraham Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

roryabraham Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham commented Aug 5, 2026

Uh oh!

joekaufmanexpensify commented Aug 5, 2026

Uh oh!

jmusial commented Aug 6, 2026

Uh oh!

jmusial commented Aug 7, 2026

Uh oh!

shubham1206agra Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Aug 7, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

OSBotify commented Aug 10, 2026

Uh oh!

MelvinBot commented Aug 10, 2026

Uh oh!

OSBotify commented Aug 12, 2026

jmusial commented Jun 29, 2026 •

edited

Loading

codecov Bot commented Jun 29, 2026 •

edited by github-actions Bot

Loading

jmusial Aug 6, 2026 •

edited

Loading