Display SearchForReports results in proper tiers order by carlosmiceli · Pull Request #94362 · Expensify/App

carlosmiceli · 2026-06-23T19:58:34Z

Explanation of Change

The chat-finder ordered results entirely client-side (report kind + recency) and ignored the order SearchForReports returns, so the backend's tier ranking was discarded.

The backend now returns an ordered searchResultReportIDs list reflecting its search tiers:

Active (primary) workspace reports
DMs with people on your email domain
Reports in your other workspaces
DMs with everyone else

This PR orders the chat-finder by that list when present, and renders the selfDM first (it's gets it from Onyxand the rest as a single ordered list.

Screen.Recording.2026-06-25.at.8.56.37.AM.mov

Fixed Issues

https://github.com/Expensify/Expensify/issues/530969

PROPOSAL:

Tests

Open the search router (Cmd+K).
Search a term matching chats across multiple tiers (your primary workspace + DMs + other workspaces).
Verify results display in the backend's tier order: self, then your primary workspace chats (including rooms like #admins), then same-domain DMs, then other-workspace chats, then other DMs.
Verify the list updates to that order once the search returns.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

carlosmiceli · 2026-06-24T02:55:23Z

@codex review

carlosmiceli · 2026-06-24T02:55:44Z

@MelvinBot fix eslint

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>

MelvinBot · 2026-06-24T03:01:54Z

🤖 Fixed the failing ESLint check.

The error was an unnecessary type assertion in tests/unit/SearchAutocompleteListTest.tsx:476 (@typescript-eslint/no-unnecessary-type-assertion): the typeof el.props.children === 'string' check already narrows the type to string, so the as string cast was redundant. Removed it.

Verified locally with ./scripts/lint.sh on all changed files — clean.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c2c1d4039

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…esult-order

…' into cm-searchforreports-result-order

codecov · 2026-06-24T20:53:46Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/components/Search/SearchAutocompleteList.tsx	`92.71% <100.00%> (+0.41%)`	⬆️
src/libs/ExportOnyxState/common.ts	`80.95% <ø> (ø)`
src/libs/actions/Report/index.ts	`71.41% <100.00%> (+0.01%)`	⬆️
src/setup/index.ts	`100.00% <ø> (ø)`
... and 7 files with indirect coverage changes

melvin-bot · 2026-06-25T12:00:12Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

carlosmiceli · 2026-06-25T12:03:35Z

@sobitneupane this will not work fully until we deploy the BE PRs, but it should also be backwards compatible, so let's test that too.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2e2f2669c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…present

huult · 2026-06-25T16:46:57Z

👍

huult · 2026-06-26T03:04:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

huult · 2026-06-29T02:30:18Z

Screen.Recording.2026-06-29.at.09.29.25.mov

@carlosmiceli Tag me when the backend PR is merged. I'll review this PR again.

carlosmiceli · 2026-06-29T19:17:34Z

@huult sounds good! Thanks!

huult · 2026-07-07T00:57:49Z

@carlosmiceli Tag me when the backend is ready.

…esult-order

huult · 2026-07-09T01:10:53Z

@carlosmiceli The unit test is failing. Could you take a look?

…esult-order

huult · 2026-07-20T05:57:13Z

@carlosmiceli Tag me when the backend is ready.

huult · 2026-07-23T02:27:11Z

@carlosmiceli Can I ask if the backend changes are ready yet? If so, can I re-review this PR?

huult · 2026-07-24T06:45:27Z

@carlosmiceli Could you sync this branch with main?

huult · 2026-08-03T04:44:50Z

@carlosmiceli could you please sync with main to resolve the conflict?

carlosmiceli · 2026-08-03T08:08:49Z

@MelvinBot please merge main and fix conflicts.

@huult sorry for being slow here, we're still needing to confirm some BE improvements before we can proceed with the App PR. Will let you know when it's ready to review 🙇

…esult-order Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com> # Conflicts: # src/components/Search/SearchAutocompleteList.tsx

MelvinBot · 2026-08-03T08:23:13Z

🤖 Merged main and resolved the conflict.

There was one conflict, in src/components/Search/SearchAutocompleteList.tsx — the useMemo dependency array around the getSearchOptions call. This branch added searchResultReportIDs as a dependency while main added translate. Both variables are referenced inside the memo body (searchResultReportIDs for the maxResults guard, translate in the getSearchOptions args), so I kept both dependencies. The rest of the file auto-merged.

The PR now shows as mergeable.

Note on local validation

I couldn't run the local lint/typecheck suite in this environment, so I verified the resolution statically: both dependencies are in scope (searchResultReportIDs from useOnyx, translate from useLocalize) and each is used inside the callback, which is exactly what react-hooks/exhaustive-deps requires — dropping either is what would flag a lint error, not keeping both. Please rely on CI for the full check run.

…esult-order

flodnv · 2026-08-18T09:51:05Z

+            }
        } else {
-            // Active search: split rows into local (frozen order) and server sections.
+            // Active search without a server order yet: split rows into local (frozen order) and server sections.


Can we remove this else branch?

I think there's a risk that rows already on screen get reshuffled while the user is already seeing reports stored locally, but maybe @huult can confirm.

carlosmiceli · 2026-08-18T11:32:22Z

@MelvinBot merge main and fix tests if failing.

carlosmiceli · 2026-08-18T11:35:33Z

@huult the BE PRs have been merged, but still not deployed, will let you know when they are so you can start reviewing/testing.

…esult-order Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>

MelvinBot · 2026-08-18T11:56:09Z

🤖 Merged main into cm-searchforreports-result-order and pushed the merge commit (92cc474).

No merge conflicts — the merge was clean.
Ran the required local checks against the touched files:
- npm run typecheck → PASS (0 errors)
- npm test tests/unit/SearchAutocompleteListTest.tsx tests/actions/ReportTest.ts → PASS (293/293)
No code changes were needed — nothing was failing.

CI will now run the full suite on the updated branch.

huult · 2026-08-19T01:13:26Z

@huult the BE PRs have been merged, but still not deployed, will let you know when they are so you can start reviewing/testing.

Thanks! I’ll review the PR once the backend is ready.

carlosmiceli added 4 commits June 23, 2026 16:55

Add RAM_ONLY_SEARCH_RESULT_REPORT_IDS Onyx key and type

b368e72

Register search result order key as RAM-only

c14d092

Order search results by Auth's tier order

1bb4fb5

Test search results follow Auth's tier order

9c2c1d4

melvin-bot Bot assigned carlosmiceli Jun 23, 2026

carlosmiceli assigned MelvinBot Jun 24, 2026

Fix: remove unnecessary type assertion flagged by ESLint

251d4fb

Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx

carlosmiceli added 3 commits June 24, 2026 16:51

Rank the selfDM first in search regardless of the server order

6883d69

Merge remote-tracking branch 'origin/main' into cm-searchforreports-r…

5622b07

…esult-order

Merge remote-tracking branch 'origin/cm-searchforreports-result-order…

9d23175

…' into cm-searchforreports-result-order

Test selfDM ranks first when absent from the server order

aa646cc

carlosmiceli changed the title ~~Display SearchForReports results in Auth's tier order~~ Display SearchForReports results in proper tiers order Jun 25, 2026

carlosmiceli added 2 commits June 25, 2026 00:24

Trim the RAM-only justification from the searchResultReportIDs comment

17d7185

Clear the stale search result order when a new search starts

2e2f266

carlosmiceli marked this pull request as ready for review June 25, 2026 12:00

carlosmiceli requested review from a team as code owners June 25, 2026 12:00

melvin-bot Bot requested review from flaviadefaria and sobitneupane and removed request for a team June 25, 2026 12:00

melvin-bot Bot removed the request for review from a team June 25, 2026 12:00

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread src/components/Search/SearchAutocompleteList.tsx

Widen the candidate pool to the full match set when an Auth order is …

bfc4167

…present

carlosmiceli removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 25, 2026

carlosmiceli requested a review from huult June 25, 2026 16:05

Merge remote-tracking branch 'origin/main' into cm-searchforreports-r…

dba0ca7

…esult-order

Merge remote-tracking branch 'origin/main' into cm-searchforreports-r…

ca172ff

…esult-order

Merge remote-tracking branch 'origin/main' into cm-searchforreports-r…

a82e676

…esult-order Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com> # Conflicts: # src/components/Search/SearchAutocompleteList.tsx

quinthar added #migrate and removed #migrate labels Aug 11, 2026

carlosmiceli added 2 commits August 16, 2026 06:43

Merge remote-tracking branch 'origin/main' into cm-searchforreports-r…

1c5a097

…esult-order

Classify the search result report IDs key as safe to export

a814255

flodnv requested changes Aug 18, 2026

View reviewed changes

Rephrase the search result order comments

84055af

Merge remote-tracking branch 'origin/main' into cm-searchforreports-r…

92cc474

…esult-order Co-authored-by: Carlos Miceli <carlosmiceli@users.noreply.github.com>

Uh oh!

Conversation

carlosmiceli commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

carlosmiceli commented Jun 24, 2026

Uh oh!

carlosmiceli commented Jun 24, 2026

Uh oh!

MelvinBot commented Jun 24, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jun 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 25, 2026

Uh oh!

carlosmiceli commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

huult commented Jun 25, 2026

Uh oh!

huult commented Jun 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Jun 29, 2026

Uh oh!

carlosmiceli commented Jun 29, 2026

Uh oh!

huult commented Jul 7, 2026

Uh oh!

huult commented Jul 9, 2026

Uh oh!

huult commented Jul 20, 2026

Uh oh!

huult commented Jul 23, 2026

Uh oh!

huult commented Jul 24, 2026

Uh oh!

huult commented Aug 3, 2026

Uh oh!

carlosmiceli commented Aug 3, 2026

Uh oh!

MelvinBot commented Aug 3, 2026

Uh oh!

Uh oh!

Uh oh!

flodnv Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

carlosmiceli Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Aug 18, 2026

Uh oh!

carlosmiceli commented Aug 18, 2026

Uh oh!

MelvinBot commented Aug 18, 2026

Uh oh!

huult commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

carlosmiceli commented Jun 23, 2026 •

edited

Loading

codecov Bot commented Jun 24, 2026 •

edited by github-actions Bot

Loading