Add error handling for cases where the expense may have moved before rejection by akinwale · Pull Request #92860 · Expensify/App

akinwale · 2026-06-06T11:35:23Z

Explanation of Change

This handles cases where the expense may have been moved before rejection to be handled more gracefully.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/630131
PROPOSAL: https://github.com/Expensify/Expensify/issues/630131#issuecomment-4636539760

Tests

Launch Expensify.
Create a workspace as user A (owner / admin), and invite user B (employee).
As user B (employee), create an expense report with 2 expenses ($12 and $14 for example) and submit the report.
As user A (admin), open the submitted expense report.
As user A, go offline.
As user B, move the $14 expense to a different report.
As user A, reject the $14 expense while offline.
As user A, go back online.
As user A, verify that an error message showing that the expense has already been moved or rejected is displayed.
As user A, upon dismissing the error, verify that the failed expense row is no longer displayed in the report.

Verify that no errors appear in the JS console

Offline tests

Same as QA steps.

QA Steps

Launch Expensify.
Create a workspace as user A (owner / admin), and invite user B (employee).
As user B (employee), create an expense report with 2 expenses ($12 and $14 for example) and submit the report.
As user A (admin), open the submitted expense report.
As user A, go offline.
As user B, move the $14 expense to a different report.
As user A, reject the $14 expense while offline.
As user A, go back online.
As user A, verify that an error message showing that the expense has already been moved or rejected is displayed.
As user A, upon dismissing the error, verify that the failed expense row is no longer displayed in the report.

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-30.at.18.18.12.mp4

…rejection

melvin-bot · 2026-06-06T11:35:27Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-06-11T14:21:06Z

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 918e742e37

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-11T14:24:51Z

+                    errorFields: {
+                        partial: getMicroSecondOnyxErrorWithTranslationKey('iou.rejectReport.couldNotRejectExpense'),


Surface the reject failure on a displayed error field

This writes the new failure message to transaction.errorFields.partial, but the transaction error consumers I found only render transaction.errorFields.route/waypoints or transaction.errors (for example ReportActionItem selects only transaction?.errorFields?.route, and MoneyRequestReceiptView merges route/waypoints/errors). In the offline move-then-reject failure path, the Onyx update is applied but no component reads partial, so the expected “expense could not be rejected” message is not shown. Please store this on a rendered report action/report error or wire partial into the transaction UI.

Useful? React with 👍 / 👎.

@akinwale I think this is a valid concern. From my testing, we would only see the backend error message The expense has already been moved or rejected., not this client message.

akinwale · 2026-06-21T06:52:16Z

@gijoe0295 This is ready for review.

joekaufmanexpensify

Good for product 👍

gijoe0295 · 2026-06-24T17:16:04Z

Also, when opening the expense, it flickers from the expense view to not found page:

Screen.Recording.2026-06-25.at.00.14.31.mov

Should we remove the transaction completely, and show the error at report level/full-screen modal since this transaction no longer exists/is not accessible? cc @joekaufmanexpensify as this is product choice and I can't access the internal link above.

gijoe0295 · 2026-06-24T17:22:06Z

An example of a full-screen error modal when deleting workspace:

The error comes from backend so we can only know and show that modal depending on API response which seems similar to this case.

akinwale · 2026-07-03T22:25:26Z

@joekaufmanexpensify bump on #92860 (comment) in case you missed it.

joekaufmanexpensify · 2026-07-16T14:43:25Z

I'm not totally sold on showing the error at the report level. This would potentially be an error they see much later on, right? If they were offline for a while and then go back on later, it may not be immediately clear what the error relates to.

Don't we have a pattern where we show an expense on a report with lower opacity and make it dismissible with an error? I think we use it if you try and scan a receipt and the scan fails. Maybe that could work well here?

aldo-expensify · 2026-07-23T00:08:42Z

friendly bump @akinwale

gijoe0295 · 2026-07-23T09:22:37Z

Oops sorry @akinwale turn

codecov · 2026-07-30T23:06:08Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...stReportView/MoneyRequestReportTransactionItem.tsx	`82.92% <100.00%> (+82.92%)`	⬆️
src/libs/actions/IOU/RejectMoneyRequest.ts	`84.13% <100.00%> (+6.95%)`	⬆️
src/libs/actions/Transaction.ts	`80.44% <100.00%> (ø)`
... and 15 files with indirect coverage changes

akinwale · 2026-07-31T00:29:21Z

@gijoe0295 I pushed a follow-up backend fix for this. Once that is deployed, I will ping you to let you know that the App changes are ready for review.

akinwale · 2026-08-05T14:35:03Z

@gijoe0295 The Web-E PR was deployed to production. This is ready for review.

gijoe0295 · 2026-08-17T09:04:59Z

Bug: I need to close the report RHP then reopen for the error to show up:

Untitled.mov

gijoe0295 · 2026-08-17T09:28:52Z

Bug: The deleted expense RHP is automatically dismissed after opening. I think we should block opening it.

Screen.Recording.2026-08-17.at.16.28.11.mov

gijoe0295 · 2026-08-17T09:29:44Z

We might need to add top padding/margin for the RBR:

gijoe0295 · 2026-08-17T09:06:31Z

            rejectedNextStep: 'This report was rejected. Waiting on you to fix the issues and manually resubmit.',
            selectMemberError: 'Select a member to reject this report back to.',
            couldNotReject: 'The report could not be rejected. Please try again.',
+            couldNotRejectExpense: 'The expense could not be rejected.',


The error message I received is The expense has already been moved or rejected. which is a backend error, not this.

gijoe0295 · 2026-08-17T09:20:12Z

+    // `Transaction.errors` also carries receipt errors, which are objects rendered by their own save/delete UI, so
+    // keep only the plain message errors here.
+    const messageErrors: Errors = Object.fromEntries(
+        Object.entries(transaction.errors ?? {}).filter((entry): entry is [string, string | null] => typeof entry[1] === 'string' || entry[1] === null),
+    );


I think ErrorUtils.getLatestErrorMessageField already filters out receipt errors, no?

gijoe0295 · 2026-08-17T09:20:30Z

+    // A failed action (e.g. rejecting an expense that has already moved) leaves the expense in place with no pending
+    // action, so opacity has to be forced — `OfflineWithFeedback` only dims on its own while a write is pending.


Suggested change

// A failed action (e.g. rejecting an expense that has already moved) leaves the expense in place with no pending

// action, so opacity has to be forced — `OfflineWithFeedback` only dims on its own while a write is pending.

melvin-bot · 2026-08-18T02:34:44Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

akinwale · 2026-08-18T02:38:13Z

We might need to add top padding/margin for the RBR:

Pinging @Expensify/design for thoughts on this.

…n error

dubielzyk-expensify · 2026-08-18T03:28:12Z

I expect the styling to follow all our other error rows where it's inside the row:

I know we wanna fade out the row because it's invalid, but I think we should still do that but have the error stand out like normal. cc @Expensify/design for gutcheck here

add error handling for cases where the expense may have moved before …

8f2cb66

…rejection

melvin-bot Bot assigned akinwale Jun 6, 2026

akinwale added 2 commits June 11, 2026 07:48

generated translations for iou.rejectReport.couldNotRejectExpense

c2de582

prettier fix

918e742

akinwale changed the title ~~Add error handling for cases where the expense may have moved before rejection~~ [HOLD Web-E 53502] Add error handling for cases where the expense may have moved before rejection Jun 11, 2026

Merge remote-tracking branch 'origin/main' into task-app-630101-webe

8dec039

akinwale marked this pull request as ready for review June 11, 2026 14:20

akinwale requested review from a team as code owners June 11, 2026 14:20

melvin-bot Bot requested review from gijoe0295 and joekaufmanexpensify and removed request for a team June 11, 2026 14:20

chatgpt-codex-connector Bot reviewed Jun 11, 2026

View reviewed changes

akinwale changed the title ~~[HOLD Web-E 53502] Add error handling for cases where the expense may have moved before rejection~~ Add error handling for cases where the expense may have moved before rejection Jun 21, 2026

joekaufmanexpensify previously approved these changes Jun 23, 2026

View reviewed changes

This comment was marked as outdated.

Sign in to view

Merge remote-tracking branch 'origin/main' into task-app-630101-webe

29fd1e0

dismiss the failed expense row when the user dismisses the error message

af5fd88

akinwale dismissed joekaufmanexpensify’s stale review via af5fd88 July 31, 2026 00:26

gijoe0295 suggested changes Aug 17, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

akinwale added 2 commits August 17, 2026 20:13

Merge remote-tracking branch 'origin/main' into task-app-630101-webe

af00eba

display the error message from the translation key

8b53799

disable the expense row if the expense was deleted elsewhere or has a…

3f2050e

…n error

add unit tests

d8115a3

akinwale force-pushed the task-app-630101-webe branch from 8adab49 to d8115a3 Compare August 18, 2026 05:21

		errorFields: {
		partial: getMicroSecondOnyxErrorWithTranslationKey('iou.rejectReport.couldNotRejectExpense'),

		// A failed action (e.g. rejecting an expense that has already moved) leaves the expense in place with no pending
		// action, so opacity has to be forced — `OfflineWithFeedback` only dims on its own while a write is pending.

Uh oh!

Conversation

akinwale commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 6, 2026

Uh oh!

melvin-bot Bot commented Jun 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

akinwale commented Jun 21, 2026

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

gijoe0295 commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gijoe0295 commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akinwale commented Jul 3, 2026

Uh oh!

joekaufmanexpensify commented Jul 16, 2026

Uh oh!

aldo-expensify commented Jul 23, 2026

Uh oh!

This comment was marked as outdated.

gijoe0295 commented Jul 23, 2026

Uh oh!

codecov Bot commented Jul 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

akinwale commented Jul 31, 2026

Uh oh!

akinwale commented Aug 5, 2026

Uh oh!

gijoe0295 commented Aug 17, 2026

Uh oh!

gijoe0295 commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gijoe0295 commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gijoe0295 Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Aug 17, 2026

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

melvin-bot Bot commented Aug 18, 2026

Uh oh!

akinwale commented Aug 18, 2026

Uh oh!

dubielzyk-expensify commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

akinwale commented Jun 6, 2026 •

edited

Loading

gijoe0295 commented Jun 24, 2026 •

edited

Loading

gijoe0295 commented Jun 24, 2026 •

edited

Loading

codecov Bot commented Jul 30, 2026 •

edited by github-actions Bot

Loading

gijoe0295 commented Aug 17, 2026 •

edited

Loading

gijoe0295 commented Aug 17, 2026 •

edited

Loading