Skip to content

[No QA] Update training session times for daylight saving - #84100

Merged
stephanieelliott merged 2 commits into
mainfrom
RachCHopkins-patch-4
Mar 10, 2026
Merged

[No QA] Update training session times for daylight saving#84100
stephanieelliott merged 2 commits into
mainfrom
RachCHopkins-patch-4

Conversation

@RachCHopkins

Copy link
Copy Markdown
Contributor

Explanation of Change

Updated in line with US daylight saving changes

Fixed Issues

https://github.com/Expensify/Expensify/issues/607041

Tests

N/A

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

@RachCHopkins RachCHopkins self-assigned this Mar 4, 2026
Comment thread docs/articles/new-expensify/getting-started/How-to-Access-Expensify-Training.md Outdated
@github-actions

github-actions Bot commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a focused, necessary update to three timezone conversion lines in the training session schedule, switching US timezone abbreviations from standard time (PST/EST) to daylight saving time (PDT/EDT) and adjusting the corresponding local hours to remain consistent with the unchanged UTC times. The changes are accurate for the US daylight saving period.

Scores Summary

  • Readability: 9/10 - The changed lines are clear and follow the same parenthetical format used throughout the file. The timezone conversions are easy to scan.
  • AI Readiness: 9/10 - No impact on headings, metadata, or document structure. The changes are purely data corrections within the body text.
  • Style Compliance: 9/10 - The changes maintain consistent formatting with the rest of the document. Timezone abbreviations and time formats are applied uniformly across all three modified lines.

Key Findings

  • Timezone math is correct for the US daylight saving period. All three US timezone conversions (PDT and EDT) are accurately calculated from the stated UTC times:
    • 23:00 UTC = 4pm PDT (correct)
    • 18:00 UTC = 11am PDT / 2pm EDT (correct)
    • 14:00 UTC = 10am EDT (correct)
  • Non-US timezones were intentionally left unchanged, which is reasonable since NZ, SYD, MNL, GMT, and CEST are outside the scope of US daylight saving. However, it is worth noting that the NZ and SYD local times (12pm NZ, 10am SYD on the Monday session) will become inaccurate once Southern Hemisphere daylight saving ends in early April, since those regions will shift back by one hour. This is a pre-existing concern and outside the scope of this PR, but may warrant a follow-up update in April.
  • Pre-existing note on the Wednesday session: The label "3pm CEST" (line 43, unchanged) appears to be inaccurate. CEST is UTC+2, so 14:00 UTC would be 4pm CEST, not 3pm. During European winter (CET, UTC+1), it would be 3pm CET. Since this was not modified in this PR, it is not scored against these changes, but it may be worth correcting in a follow-up.
  • Seasonal maintenance concern: These timezone parentheticals will need to be updated again when US daylight saving ends in November. Consider adding a comment or internal note to flag this as a recurring maintenance task, or consider whether displaying only UTC times (which never change) might reduce long-term maintenance burden.

Recommendations

  1. Merge as-is -- the proposed changes are correct and necessary for the current US daylight saving period.
  2. Consider a follow-up PR to correct the "3pm CEST" label on the Wednesday session (pre-existing issue, not introduced by this PR).
  3. Consider a follow-up PR in early April to update NZ and SYD local times when Southern Hemisphere daylight saving ends.
  4. Long-term: Evaluate whether maintaining multiple local-time conversions is sustainable, or whether linking to a timezone converter tool might reduce recurring update needs.

Files Reviewed

  • docs/articles/new-expensify/getting-started/How-to-Access-Expensify-Training.md -- 3 lines changed. All US timezone conversions are accurate. No formatting, structural, or style issues introduced.

@OSBotify

OSBotify commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://ecad646c.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott

Copy link
Copy Markdown
Contributor

Hey @RachCHopkins do you wanna address these bot comments? Seems like some of the times may be incorrect. If not, feel free to just dismiss the bot comments

@RachCHopkins

Copy link
Copy Markdown
Contributor Author

I am really bad with timezones, like terrible. So I'm inclined to trust the bot. I might get someone else to check it for me on Monday just in case.

@RachCHopkins

Copy link
Copy Markdown
Contributor Author

@stephanieelliott all resolved and had @kadiealexander buddy-check me. I think Melvin is being overly cautious.

@RachCHopkins

Copy link
Copy Markdown
Contributor Author

Changed CEST to CET - apparently the S stands for "summer" not "standard". Standard time is just CET.

@stephanieelliott
stephanieelliott merged commit 26ccc41 into main Mar 10, 2026
13 checks passed
@stephanieelliott
stephanieelliott deleted the RachCHopkins-patch-4 branch March 10, 2026 00:18
@melvin-bot melvin-bot Bot added the Emergency label Mar 10, 2026
@melvin-bot

melvin-bot Bot commented Mar 10, 2026

Copy link
Copy Markdown

@stephanieelliott looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@stephanieelliott

Copy link
Copy Markdown
Contributor

Great, thanks @RachCHopkins - merged!

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.3.35-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.3.35-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants