[No QA] [DO NOT MERGE] Helpsite consolidate v2 - #81597
Conversation
stephanieelliott
changed the title
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@srikarparsi @jliexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ## Setting Up Personal Karma Donations | ||
|
|
||
| You can enable Personal Karma donations from your personal workspace settings. | ||
|
|
There was a problem hiding this comment.
Terminology violation: Use "workspace" instead of "Workspace" in this context. The term should be lowercase when referring to the concept generically, not as a UI label.
|
|
||
| ## Corporate Karma | ||
|
|
||
| Corporate Karma is for companies that want to engage in social responsibility. Each month, the donation is calculated based on the total amount of all approved expense reports, including invoices, across all Workspace. |
There was a problem hiding this comment.
Terminology violation: Use "workspace" (lowercase) instead of "Workspace" when referring to the general concept. Also, the phrase "across all Workspace" is grammatically incorrect - it should be "across all workspaces" (plural).
| @@ -0,0 +1,33 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve AI readability and help users understand where this article fits in the documentation structure. Example: Settings > Account > Subscription
| # Who can resolve out-of-date billing | ||
|
|
||
| Only the **billing owner** can fix billing issues. | ||
|
|
There was a problem hiding this comment.
AI Readiness violation: The phrase "transfer billing ownership" lacks clear context. Consider adding a brief explanation or linking to documentation about what billing ownership is and how to transfer it.
| - Retry failed payments | ||
| - Upgrade from a trial to a paid subscription | ||
| - Transfer billing ownership if needed | ||
|
|
There was a problem hiding this comment.
Terminology violation: Use "Workspace Admins" (plural with capital W and A) to match Expensify's standard role terminology.
| @@ -0,0 +1,46 @@ | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Formatting violation: Remove the blank line before the YAML frontmatter closing delimiter ---. The frontmatter should start on line 1 without any blank lines.
|
|
||
| This article explains **how Expensify plans and pricing work**, so you can choose the plan that best fits your team and understand how billing is calculated. Pricing, eligibility rules, and billing logic are consistent across platforms, even though pricing may be displayed differently in New Expensify and Expensify Classic. | ||
|
|
||
| # Choose the right Expensify plan |
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to show users where they are in the help documentation structure and improve AI readability.
| @@ -0,0 +1,80 @@ | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Formatting violation: Remove the blank line before the YAML frontmatter closing delimiter ---. The frontmatter should start on line 1 without any blank lines.
| internalScope: Audience is Workspace Admins and Billing Owners. Covers how the Expensify Card impacts pricing and cash back logic. Does not cover card setup, card management, or reconciliation workflows. | ||
| --- | ||
|
|
||
| # Expensify Card: How Pricing Discounts and Cash Back Work |
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
HelpDot Documentation ReviewOverall AssessmentThis PR introduces a new consolidated billing hub with 17 new documentation articles covering subscription management, billing ownership, plans and pricing, and other billing scenarios. The documentation demonstrates strong AI readiness with excellent metadata structure, though there are several areas requiring attention before merge. Scores Summary
Key FindingsStrengths:
Critical Issues:
Moderate Issues:
RecommendationsPriority 1 (Must Fix Before Merge):
Priority 2 (Should Fix):
Priority 3 (Nice to Have):
Files ReviewedSubscription Management (4 files):
Subscription Setup & Billing Ownership (5 files):
Plans and Pricing (5 files):
Other Billing Scenarios (3 files):
Infrastructure Files:
SummaryThis is a substantial documentation effort with strong AI optimization. The content is comprehensive and well-organized, but requires fixes to broken links, capitalization, and placeholder content before it can be merged. Once these issues are addressed, this will be a valuable addition to the HelpDot documentation. Note: Detailed line-by-line feedback can be provided as inline comments if needed. |
| @@ -0,0 +1,72 @@ | |||
| --- | |||
| title: Expensify Legacy Pricing: Who Qualifies and What It Means | |||
There was a problem hiding this comment.
Formatting violation: Remove the blank line before the YAML frontmatter closing delimiter ---. The frontmatter should start on line 1 without any blank lines.
| @@ -0,0 +1,78 @@ | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Formatting violation: Remove the blank line before the YAML frontmatter closing delimiter ---. The frontmatter should start on line 1 without any blank lines.
| @@ -0,0 +1,92 @@ | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
Formatting violation: Remove the blank line before the YAML frontmatter closing delimiter ---. The frontmatter should start on line 1 without any blank lines.
| @@ -0,0 +1,91 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability. This helps users understand where they are in the documentation structure.
| @@ -0,0 +1,114 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| @@ -0,0 +1,171 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| @@ -0,0 +1,105 @@ | |||
| <!-- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| @@ -0,0 +1,93 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| @@ -0,0 +1,101 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| @@ -0,0 +1,121 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| @@ -0,0 +1,71 @@ | |||
| --- | |||
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading to improve navigation context and AI readability.
| keywords: [Expensify Classic, karma points, personal karma, corporate karma] | ||
| --- | ||
|
|
||
| [Expensify.org](https://www.expensify.org/about) is built on creating a transparent and convenient way to create an emotional connection between donors, volunteers, and recipients. The funds for this organization come from Corporate Karma, Personal Karma, and monetary donations. |
There was a problem hiding this comment.
Missing breadcrumb path: Add a breadcrumb navigation path below the H1 heading (after the YAML frontmatter) to improve navigation context and AI readability. Example: Settings > Workspaces > Individual/Group
…wnership-Means-in-Expensify.md
…visibility details for GL codes in the respective tables, clarifying their status for workspace admins and members. Update instructions for managing GL codes and improve consistency across related articles.
…removing the outdated Plan-types-and-pricing.md file. Introduced new links for Expensify Plan Types and Pricing, enhancing clarity and accessibility for users.
… and pricing, improving navigation to relevant documentation for users.
… from redirects.csv to streamline navigation and ensure users access the most relevant documentation.
Changed HTML section title from "Plans and Pricing" to "Plans & Pricing" to exactly match _routes.yml configuration. Title mismatches were causing the Jekyll site generator to treat them as separate sections, creating duplicate navigation entries. Co-authored-by: Cursor <cursoragent@cursor.com>
The createDocsRoutes.ts script auto-generates section entries from the filesystem and adds them to existing sections in _routes.yml, causing duplicates. Removed the manual section definitions from the consolidated billing hub to allow the script to generate them automatically. Co-authored-by: Cursor <cursoragent@cursor.com>
…ricing, and add new documentation files for Collect and Control Plan features, cash back benefits, and switching plans. This enhances navigation and provides comprehensive guidance for users evaluating their subscription options.
Co-authored-by: Cursor <cursoragent@cursor.com>
- Change hub icon to subscription-annual.svg - Update hub description to focus on subscription options and payment methods - Write new Subscription Overview article - Add order fields to all articles for proper section ordering - Rename article titles: * 'How to Manage Your Subscription' → 'How to configure your subscription' * 'Deleting a workspace' → 'Deleting an Expensify workspace and ending billing' - Remove version-specific navigation notes from all articles - Add Expensify Classic-only note to Personal and Corporate Karma Co-authored-by: Cursor <cursoragent@cursor.com>
- Rename article files to match their new titles: * How-to-manage-your-subscription-in-New-Expensify.md → How-to-configure-your-subscription-in-New-Expensify.md * How-to-Manage-Your-Subscription-in-Expensify-Classic.md → How-to-configure-your-subscription-in-Expensify-Classic.md * Deleting-workspaces-in-Expensify.md → Deleting-an-Expensify-workspace-and-ending-billing.md - Add section ordering to billing hub in _routes.yml: 1. Subscription Setup & Billing Ownership 2. Subscription Management 3. Plans & Pricing 4. Other Billing Scenarios - Add redirects for renamed article URLs Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
0773435 to
a3842c8
Compare
|
@MelvinBot can you help me pass the failed tests |
|
Fixed the following CI failures that were related to this PR: Prettier check — Ran Spellcheck — Added Typecheck ("Found new JavaScript files") — Converted The remaining failing checks are unrelated to this PR:
|
f0116a8 to
1b41ee7
Compare
stephanieelliott
added
the
HelpDot
Codecov Report✅ All modified and coverable lines are covered by tests. |
3 participants
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari