fix: report specific outcome tags for known AWS Glue exceptions - #146
Merged
Merged
Conversation
EntityNotFoundException, AlreadyExistsException, ConcurrentModificationException, ResourceNumberLimitExceededException, and GlueEncryptionException were falling through to the generic AmazonServiceException outcome tag in GlueSync listener metrics, obscuring the real failure type (e.g. EntityNotFoundException on alter_table for missing tables). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jmnunezizu
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
outcome:amazonserviceexceptionfor several distinct AWS Glue failures (e.g.EntityNotFoundExceptiononalter_table), obscuring the real cause.KNOWN_EXCEPTION_NAMESinApiaryGlueSyncnow includesEntityNotFoundException,AlreadyExistsException,ConcurrentModificationException,ResourceNumberLimitExceededException, andGlueEncryptionException, so each surfaces its own outcome tag instead of falling back to the genericAmazonServiceExceptionsuperclass match.toOutcome_entityNotFoundException_returnsSpecificOutcometo cover the new mapping.Test plan
ApiaryGlueSyncTestpasses, including the new test and the existing hierarchy-fallback/othertests (unaffected — they use a customUnknownGlueExceptionand a plainRuntimeException)outcome:entitynotfoundexception(and similar) now appear instead of the generic bucket🤖 Generated with Claude Code