Enable glue stats collection - #326
Merged
Merged
Conversation
added 2 commits
July 31, 2025 14:05
patduin
reviewed
Aug 1, 2025
| } | ||
|
|
||
| resource "null_resource" "automatic_glue_stats_collector_script" { | ||
| count = var.disable_glue_db_init ? 1 : 0 |
Contributor
There was a problem hiding this comment.
What does disable glue db init have to do with stats collection?
Contributor
There was a problem hiding this comment.
This now reads that if glue db init is disabled it implies we enable glue stats collection, that's confusing, we should introduce a separate flag or refactor the existing to make more sense.
Contributor
Author
There was a problem hiding this comment.
Yeah, it is not really clear, when you disable glue init from HMS readwrite, that means all the Glue new stuff + lake formation permissions starts... but I will use enable_glue variable better, thank you
patduin
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues