fix(passkey): remove unreachable return after throw - #46
Merged
Conversation
CodeQL js/unreachable-statement (mds.js, attestation/androidSafetynet.js): the `return null` after `throw new PasskeyError(...)` inside the x5c .map() callbacks is dead code. It was invisible before the error-typing pass (the old throwXxx() factory call wasn't seen as `never`); the explicit throw makes the dead statement provable. Pure cleanup — no behaviour change, so no changeset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the two open CodeQL
js/unreachable-statementalerts (#69, #70).Both are a dead
return null;immediately afterthrow new PasskeyError(...)inside anx5c.map()catch block (mds.js,attestation/androidSafetynet.js). The statement was always unreachable; it only became provable to CodeQL after the recent error-typing pass replaced thenever-returningthrowXxx()factories with an explicitthrow.Pure dead-code removal — no behaviour change, no public surface change, no changeset. passkey suite green (309).