fix(paseto): seed the SCAN cursor as a string for both clients - #31
Merged
Conversation
ExorTek
force-pushed
the
fix/paseto-scan-cursor
branch
from
August 6, 2026 09:14
4e12797 to
1f18617
Compare
`deleteAll` walked the keyspace with SCAN, starting the cursor as a number on the node-redis branch. node-redis typed cursors as numbers through v5 but requires a string from v6, and the peer range (`redis >=4.0.0`) admits v6 — so family revocation, which is what runs when refresh-token reuse is detected, failed against a current node-redis. Redis cursors are protocol strings either way, so both dialects now seed and compare a string and the branch disappears.
ExorTek
force-pushed
the
fix/paseto-scan-cursor
branch
from
August 6, 2026 09:17
1f18617 to
a3ce1a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #30. Last of the Redis series.
deleteAllwalked the keyspace withSCAN, seeding the cursor as a number on the node-redis branch. node-redis typed cursors as numbers through v5 but requires a string from v6, and the declared peer range (redis >=4.0.0) admits v6 — so family revocation, which is what runs when refresh-token reuse is detected, failed against a current node-redis.Redis cursors are protocol strings either way, so both dialects now seed and compare a string and the branch disappears.
Worth noting: paseto is the store the other fixes were modelled on, and it still had this. It only showed up once the suite ran against a second driver.
After this, every Redis suite is green on both clients with no
todomarkers left.