fix: critical correctness — case registry, watchdog overrides, transcript paths - #117
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix: critical correctness — case registry, watchdog overrides, transcript paths#117cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…verification, transcript paths - litigation/run.py: create registry on first use, fcntl lock for concurrent saves, year rollover reset, treat category 0 as first case - executive/watchdog.py: require HMAC-verified OverrideProof for override actions instead of bypassing approval checks - export_transcript.py: resolve_transcript_path() avoids double-prefix 404 - litigation/viewer.py: exact/prefix/suffix matching instead of substring Adds regression tests for all four fixes (69 tests passing). Co-authored-by: Jack J Burleson // LJM <Exios66@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily critical-correctness scan identified four high-severity bugs still present on
mainafter recent portal/test commits (#54, #66, #84).Bugs fixed
1. Duplicate Case Nos / registry corruption (
litigation/run.py)DEL-001without persisting.case-registry.yaml; early return when registry missing.fcntlexclusive lock, create registry on first use, year rollover reset,max(nnn, 1)for zero-seeded categories.2. Executive override bypass (
executive/watchdog.py)overrideinaction_typeskipped approval checks; any non-emptyoverride_proofbypassed verification.OverrideProof.verify().3. Portal export 404 (
courtroom/portal/export_transcript.py)courtroom/transcripts/foo.mdresolved to nonexistentcourtroom/courtroom/transcripts/foo.md.BASE_DIR / args.transcriptdouble-prefixed when path already includedcourtroom/.resolve_transcript_path()strips repo-root prefix before joining.4. Wrong transcript served (
litigation/viewer.py)barmatchedfoo-barvia substring (name in stem).cmd_showand HTTP handler.-{name}/_{name}) matching via_resolve_transcript().Validation
python3 -m pytest tests/)