fix: critical correctness — case registry locking, watchdog proof verification, viewer/export paths - #113
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
…ing, export paths - allocate_case_no: create registry when missing, exclusive fcntl lock, fsync, and year rollover reset to prevent duplicate Case Nos under concurrent saves - watchdog: require OverrideProof.verify() for override actions instead of skipping checks when action_type contains override or proof is non-empty - litigation viewer: resolve transcripts by exact/prefix/suffix rules, not arbitrary substring match (bar must not match foo-bar) - export_transcript: resolve_transcript_path strips courtroom/ prefix so repo-root paths do not double-prefix to courtroom/courtroom/transcripts Co-authored-by: Jack J Burleson // LJM <Exios66@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Daily critical-correctness scan found four high-severity bugs still present on
mainafter recent portal path fixes (#54, #66, #84). This PR applies minimal, targeted fixes with regression tests.Bugs fixed
1. Duplicate Case Nos / registry corruption (
litigation/run.py)DEL-001without persisting.fcntllock,fsync, year rollover reset.2. Watchdog override bypass (
executive/watchdog.py)action_typecontained "override" or any non-emptyoverride_proofwas present without HMAC verification.OverrideProof.verify()for all override actions.3. Wrong transcript served (
litigation/viewer.py)name in stem) could servefoo-barwhen user requestedbar.4. Export path double-prefix (
courtroom/portal/export_transcript.py)courtroom/transcripts/foo.mdresolved to nonexistentcourtroom/courtroom/transcripts/.resolve_transcript_path()stripscourtroom/prefix before joining.Validation
python3 -m pytest tests/ -q)