test: cover litigation provider factory selection and OpenRouter config - #112
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover litigation provider factory selection and OpenRouter config#112cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for get_provider across ollama, lm_studio, and openrouter backends, including attribution headers, extra_body routing, env-based API key lookup, and missing-key errors. Co-authored-by: exios4 <exios4@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
litigation/providers/factory.py): backend selection forollama,lm_studio, andopenrouter.HTTP-Referer,X-Title),extra_bodyprovider routing and user id, env-basedOPENROUTER_API_KEYlookup, and missing-key error handling.Test files added/updated
tests/test_litigation_providers.py(new, 6 tests)Why these tests materially reduce regression risk
The litigation runner depends on
get_providerto wire the correct LLM backend for courtroom deliberations. Misconfigured OpenRouter headers or missing API key handling would fail silently or at runtime in production runs. These tests pin factory behavior without requiring live API calls.Validation
python3 -m pytest tests/— 66 passed