test(litigation): cover provider factory selection and OpenRouter config - #106
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(litigation): cover provider factory selection and OpenRouter config#106cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for ollama/lm_studio/openrouter provider wiring, OpenRouter attribution headers and extra_body, and missing API key guard. Co-authored-by: exios4 <exios4@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
litigation/providers/factory.py): provider selection for ollama, lm_studio, and openrouter backends; OpenRouter attribution headers andextra_bodyconstruction; missingOPENROUTER_API_KEYguard; unknown provider rejection; invalid/empty config edge cases.Test files added/updated
tests/test_litigation_providers.py— new (7 tests)Why these tests materially reduce regression risk
The provider factory is the single entry point for all litigation LLM backends. Misconfigured OpenRouter headers, missing API key handling, or wrong provider class selection would break courtroom deliberation runs silently or at runtime with opaque errors. These tests lock the wiring without requiring live API calls.
Validation
67 passed