test(litigation): cover provider factory selection and OpenRouter config - #101
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(litigation): cover provider factory selection and OpenRouter config#101cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add regression tests for get_provider (ollama, lm_studio, openrouter), OpenRouter header/extra_body builders, and missing API key validation. Co-authored-by: exios4 <exios4@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
get_provider()factory: ollama/lm_studio/openrouter selection, case-insensitive provider names, and unknown-provider rejectionOPENROUTER_API_KEYenv or explicit key)HTTP-Referer,X-Title) and routingextra_body(provider,user) passed through toOpenAICompatProviderTest files added/updated
tests/test_litigation_providers.py(8 tests, new)Why these tests materially reduce regression risk
The litigation runner depends on correct provider wiring for every courtroom session. A regression in factory selection or OpenRouter config propagation would silently route requests to the wrong backend or omit required headers. These tests lock the factory contract without requiring live API calls.
Validation:
pip install -e ".[dev]" && python3 -m pytest tests/— 68 passed