PR to trach changes with main.. DO NOT MERGE . LOCAL FORK PR - #1
Open
ExceptionalHandler wants to merge 110 commits into
Open
PR to trach changes with main.. DO NOT MERGE . LOCAL FORK PR#1ExceptionalHandler wants to merge 110 commits into
ExceptionalHandler wants to merge 110 commits into
Conversation
Export functions used to manipulate fd_t. This makes the use of the UCRT _get_osfhandle an implementation detail which is abstracted away from users of ebpfapi.dll. This also makes it easier to use the API via run-time dynamic linking.
Allow retrieving the fd from a link while destroying the link. It would be nicer to avoid the indirection via link, but that is a bigger change.
Add a function to load a native image without going through the bpf_object abstraction. The function expects program and map fd arrays to be allocated by the caller because dealing with memory which is dynamically allocated in C/C++ is quite cumbersome in Go. Returns a size hint and a well known error in case the arrays are too small.
Allow users to resolve libbpf style enums to Windows GUIDs.
Compiling against Windows eBPF headers produces object files which are not easily distinguishable from object files compiled against Linux headers. This is a problem for cross-platform tooling which wishes to inspect the contents of an ELF. Emit a section .ebpf_for_windows with the contents 0x01 into ELFs compiled against the windows headers. Updates #3956
Add support for creating nested maps via the bpf() syscall wrapper. Updates #3729
Allow passing a name for maps and programs and allow retrieving it via BPF_OBJ_GET_INFO_BY_FD. This requires a bunch of glue code because the bpf_prog_info, etc. structs are not compatible with Linux.
Bumps [external/ubpf](https://github.com/iovisor/ubpf) from `859e35c` to `c494992`. - [Commits](iovisor/ubpf@859e35c...c494992) --- updated-dependencies: - dependency-name: external/ubpf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sharmi <shpalan@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Bumps [external/ubpf](https://github.com/iovisor/ubpf) from `c494992` to `f5e6778`. - [Commits](iovisor/ubpf@c494992...f5e6778) --- updated-dependencies: - dependency-name: external/ubpf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…(#4091) Bumps the actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.27.6 to 3.27.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@aa57810...df409f7) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* First attempt at filing bugs if WDK is out-of-date Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Update .github/workflows/check_wdk.yml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update .github/workflows/check_wdk.yml Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Fix script Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Add mitigiation steps Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
… purposes (#4003) * add to zombie list (untested * fix * fix * CR feedback * CR comments * cleanup --------- Co-authored-by: Alan Jowett <alanjo@microsoft.com> Co-authored-by: Anurag Saxena <43585259+saxena-anurag@users.noreply.github.com>
Update setup-ebpf.ps1 to also explicitly grant LOCAL SERVICE permission to execute the required debug DLLS. This seems to be necessary to avoid error 1053 when installing on a new system via SSH.
* bpf(): improve map and program compatibility Allow passing a name for maps and programs and allow retrieving it via BPF_OBJ_GET_INFO_BY_FD. This requires a bunch of glue code because the bpf_prog_info, etc. structs are not compatible with Linux. * Fix test failure due to incorrect link type * Address feedback from Dave Thaler * Fix second test failure due to wrong link type * Use program ID 0 on detached link ids Internally both zero and EBPF_ID_NONE are used to refer to non-existing ID. Use zero when retrieving link info, since that aligns with Linux better. * Temporarily use BPF_LINK_TYPE_UNSPEC * Only test program info if JIT is enabled * Apply suggestions from dthaler's review Co-authored-by: Dave Thaler <dthaler1968@gmail.com> --------- Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Bumps the actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/upload-artifact` from 4.4.3 to 4.5.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b4b15b8...6f51ac0) Updates `codecov/codecov-action` from 5.1.1 to 5.1.2 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@7f8b4b4...1e68e06) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [external/ubpf](https://github.com/iovisor/ubpf) from `f5e6778` to `0aa26cd`. - [Commits](iovisor/ubpf@f5e6778...0aa26cd) --- updated-dependencies: - dependency-name: external/ubpf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…(#4106) Bumps the actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.27.9 to 3.28.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@df409f7...48ab28a) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* Add required permissions Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Update the WDK Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* Build full native-only variant on ARM64 Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Fix arm64 dependencies Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Skip downloading demo repo for arm64 Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Skip downloading demo repo for native only Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Fix nativeonly release arm64 Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Resolve merge conflict Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Build only ELF during cross-compilation Signed-off-by: Alan Jowett <alanjo@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* Check if test process failed to start. * add .exe extension.
* Update to latest ebpf-verifier Signed-off-by: Alan Jowett <alanjo@microsoft.com> * API contract changes Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Fix test failure Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: StepSecurity Bot <bot@stepsecurity.io> Co-authored-by: Alan Jowett <alanjo@microsoft.com>
Bumps the actions group with 4 updates in the / directory: [step-security/harden-runner](https://github.com/step-security/harden-runner), [actions/upload-artifact](https://github.com/actions/upload-artifact), [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) and [github/codeql-action](https://github.com/github/codeql-action). Updates `step-security/harden-runner` from 2.10.2 to 2.10.3 - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@0080882...c95a14d) Updates `actions/upload-artifact` from 4.5.0 to 4.6.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@6f51ac0...65c4c4a) Updates `peter-evans/create-pull-request` from 7.0.5 to 7.0.6 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@5e91468...67ccf78) Updates `github/codeql-action` from 3.28.0 to 3.28.1 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@48ab28a...b6a472f) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix * run 23h2 tests only * fixes - enable script execution as part of setup * possible fix, add diagnostics * additional runs for sanity * remove debugging logging * enable all tests * finalize 23h2
Bumps the actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [step-security/harden-runner](https://github.com/step-security/harden-runner) | `2.10.4` | `2.11.0` | | [actions/upload-artifact](https://github.com/actions/upload-artifact) | `4.6.0` | `4.6.1` | | [actions/cache](https://github.com/actions/cache) | `4.2.0` | `4.2.1` | | [github/codeql-action](https://github.com/github/codeql-action) | `3.28.9` | `3.28.10` | | [ossf/scorecard-action](https://github.com/ossf/scorecard-action) | `2.4.0` | `2.4.1` | Updates `step-security/harden-runner` from 2.10.4 to 2.11.0 - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@cb605e5...4d991eb) Updates `actions/upload-artifact` from 4.6.0 to 4.6.1 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@65c4c4a...4cec3d8) Updates `actions/cache` from 4.2.0 to 4.2.1 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@1bd1e32...0c907a7) Updates `github/codeql-action` from 3.28.9 to 3.28.10 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@9e8d078...b56ba49) Updates `ossf/scorecard-action` from 2.4.0 to 2.4.1 - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@62b2cac...f49aabe) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add ebpf_object_load_native_by_fds Add a function to load a native image without going through the bpf_object abstraction. The function expects program and map fd arrays to be allocated by the caller because dealing with memory which is dynamically allocated in C/C++ is quite cumbersome in Go. Returns a size hint and a well known error in case the arrays are too small. * Fix order in Source.def
* Update CODEOWNERS Introducing the missing asterisk. * Fix CODEOWNERS formatting issue
* Switch to nuget feed for llvm Disable bpf2c tests (due to different LLVM version) Signed-off-by: Alan Jowett <alanjo@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alanjo@microsoft.com> * PR feedback Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Bumps [external/ubpf](https://github.com/iovisor/ubpf) from `d682377` to `2ad882f`. - [Commits](iovisor/ubpf@d682377...2ad882f) --- updated-dependencies: - dependency-name: external/ubpf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update to latest verifier Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Set MSVC runtime version for fuzzerdebug configuration Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Co-authored-by: Laksh Kotian <lakshkotian@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* Log the version of LLVM in c:\program files\llvm\bin Signed-off-by: Alan Jowett <alanjo@microsoft.com> * Use $(ClangExec) in place of clang Signed-off-by: Alan Jowett <alanjo@microsoft.com> --------- Signed-off-by: Alan Jowett <alanjo@microsoft.com>
* Lockless ebpf_ring_buffer implementation. - eBPF ring buffer map has not been updated yet. * enable wip ringbuf stress by default * SAL fix * Comment out raise irql for testing. * Update existing ringbuf tests. * Internal helper documentation, fix irql warning. * cleanup * update tests and docs * Fix consumer advance in ebpf_api. * fix ebpf_maps.c ringbuf return, var renaming * remove yield from reserve * Add barrier to wait for all test threads to start. * cleanup * Add comments explaining producer serialization. * refresh consumer offset before reserve retry. * Update reserve comments. * Reorder acquire/release statements to reduce dependencies. * Add ring buffer documentation. * consolidate stress tests and pr feedback. * Remove ebpf_ring_buffer_return. * Add assert to ensure size_t is 64 bits. * Make ring buffer stress test more robust. * Remove debug print. * feedback * fix retval strings * fix numbering in markdown * documentation fixes - use consistent wording for lock bit - make consumer singular in RingBuffer.md - add urls for issues - fix typos * fix typo * Add locked record check in return_buffer. * Update async ops to use acquire+release for consumer. * check for locked record in ebpf_api * re comments: consistently use no-fence, typo fixes --------- Co-authored-by: Michael Agun <danielagun@microsoft.com>
Bumps [external/ebpf-verifier](https://github.com/vbpf/ebpf-verifier) from `b290e5c` to `e5e0c5b`. - [Release notes](https://github.com/vbpf/ebpf-verifier/releases) - [Commits](vbpf/prevail@b290e5c...e5e0c5b) --- updated-dependencies: - dependency-name: external/ebpf-verifier dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the actions group with 4 updates: [actions/cache](https://github.com/actions/cache), [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request), [actions/download-artifact](https://github.com/actions/download-artifact) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/cache` from 4.2.1 to 4.2.2 - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@0c907a7...d4323d4) Updates `peter-evans/create-pull-request` from 7.0.6 to 7.0.7 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@67ccf78...dd2324f) Updates `actions/download-artifact` from 4.1.8 to 4.1.9 - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@fa0a91b...cc20338) Updates `codecov/codecov-action` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@13ce06b...0565863) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Export a function which allows retrieving the object info along with its type. bpf_obj_get_info_by_fd is almost what we need, but doesn't allow determining the type of the object.
* Fix race condition in _invalid_parameter_suppression Invalid parameter suppression currently sets the global invalid parameter handler. This means that concurrent execution may lead to executing the wrong handler. Instead, always set and restore the thread local handler. * Write debug assertions to stderr before terminating process Report assertions and errors to standard error before terminating the process. Stop changing the reporting mode in _invalid_parameter_suppression because the mode is a global setting which shouldn't be changed by a library. Fixes microsoft/ebpf-for-windows#4207
* fix * fix * add reference * fix * fix * temp change * increase test time * code cleanup * code cleanup * remove reference logic * delete stale comment * fix, cr comments
Bumps [external/ubpf](https://github.com/iovisor/ubpf) from `2ad882f` to `8782fd3`. - [Commits](iovisor/ubpf@2ad882f...8782fd3) --- updated-dependencies: - dependency-name: external/ubpf dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#4202) Bumps the generic group with 1 update in the / directory: [tests/external/kissfft](https://github.com/mborgerding/kissfft). Updates `tests/external/kissfft` from `f5f2a3b` to `febd4ca` - [Release notes](https://github.com/mborgerding/kissfft/releases) - [Commits](mborgerding/kissfft@f5f2a3b...febd4ca) --- updated-dependencies: - dependency-name: tests/external/kissfft dependency-type: direct:production dependency-group: generic ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* run only ws2025 tests * add some diagnositcs failfast * fix * fix * fix * fix - don't failfast in init * debug info * WIP * debug logs * fix * fix * extra tracing * more debugging * fix * refactor safe require to common * fix * fix * fix * correct trace command * add some extra diagnostics, add failfast * fixes * ensure we stop netebpfext * try fixes * update max size param * fix * run only one set of CR tests * run only nonadmin user tests * run both tets * tests * fix * more debug tracing * scope tests down more * scope tests further * more minor diagnostics, add missing check for detatch in progress * scale down tests more * potential workaround fix * fix * cleanup, fix for douloe removal of list entry * fix double remove * fix * add extra test run, add tracing * only collect netebpfext traces * fixes * collect traces later * more diagnostics * revert a bunch of temporary test disablements * code cleanup to prepare for check in - pt 1 * move to kesingle object * commit missing file * fix * temporarily add back debug log capture * rename zombie * update comments * revert temporary changes, but leave in testing for last iteration * fix analyze warning, fix tests by properly ordering init and cleanup * fix * fix * fix * prepare for check in * enable stress tests now that its fixed * CR feedback * CR feedback * CR
Bumps the actions group with 2 updates: [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) and [github/codeql-action](https://github.com/github/codeql-action). Updates `peter-evans/create-pull-request` from 7.0.7 to 7.0.8 - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@dd2324f...271a8d0) Updates `github/codeql-action` from 3.28.10 to 3.28.11 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@b56ba49...6bb031a) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [external/ebpf-verifier](https://github.com/vbpf/ebpf-verifier) from `e5e0c5b` to `d4d0336`. - [Release notes](https://github.com/vbpf/ebpf-verifier/releases) - [Commits](vbpf/prevail@e5e0c5b...d4d0336) --- updated-dependencies: - dependency-name: external/ebpf-verifier dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* remove @exception from documentation. * Making documentation consistent with Linux. * PR Feedback. * Fix spelling mistake.
Building the sample project fails if the clang path contains a space. Fix this by quoting "$(ClangExec)".
…sion of 'package' directory. (#4278)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?