Repository navigation
fix(security): baseline crypto-bigint advisory and encrypt alarms SNS topic - #904
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This was referenced Nov 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Clears the two report-only Security Gates findings left after #901: the cargo-audit advisory RUSTSEC-2026-0387 and Trivy AWS-0095 on the ALB alarms SNS topic.
Closes #902
Closes #903
Feature Summary
contracts/.cargo/audit.tomlbaselines RUSTSEC-2026-0387 with reason and review dateaws_sns_topic.alb_alarmsencrypted with a customer-managed KMS key (rotation on)Technical Implementation
elliptic-curve ^0.13. It is host-side only;cargo tree -e normal --target wasm32-unknown-unknown -i crypto-bigintis empty, so it is not in the deployed wasm. Entry is ignored with a review-by date of 2027-02-01 and is removed once soroban-env-host moves to elliptic-curve 0.14. The 6 remaining warnings (unmaintained/unsound/yanked) do not failcargo audit.infra/waf-and-alarms.tf: newaws_kms_key.alb_alarmswithenable_key_rotation = trueand a key policy granting the account admin pluscloudwatch.amazonaws.comkms:Decryptandkms:GenerateDataKey*. The AWS-managedalias/aws/snskey is not used because CloudWatch alarms cannot publish to a topic encrypted with it. Topic setskms_master_key_id.Test Coverage
cargo auditincontracts/: exit 1 without the baseline, exit 0 with itconfig --severity HIGH,CRITICALoninfra/: AWS-0095 reported before, no findings afterterraform fmt -checkpasses.terraform validatenot run:infra/is a partial module (referencesaws_lb.mainandvar.environmentdefined elsewhere)Checklists
Issue Definition of Done
contracts/.cargo/audit.tomlwith a documented reason and review datecargo auditpasses incontracts/./scripts/ci-local.sh contractspasses (left to CI; no Rust source or Cargo.lock change)aws_sns_topic.alb_alarmsencrypted with a customer-managed KMS key with rotation enabledGeneral
./scripts/ci-local.sh <area>and it passes (no area coversinfra/; cargo audit and Trivy run directly instead).github/THREAT_MODEL.mdattached and maintainer review requested