[ExcelDsigN-tech]

Summary

Fixes four bugs: build-error misclassification in stellar.service (#1633), a payout parity test that never touched backend code (#1636), deep links that never navigated (#1637), and createTradeSchema stripping deliveryDays (#1639).

Type of Change

• Bug fix (non-breaking change fixing an issue)

Changes Made

• stellar.service: buildTransaction only reports "Invalid transaction operations" for local build failures or Horizon result_codes.operations, not any message containing "operation" (#1633)
• feeAccounting.service: restored the file (241b228 truncated it), added calculateDisputePayout; dispute.payout.parity.test now tests it instead of a test-local copy (#1636)
• AppNavigator: holds a NavigationContainerRef and navigates the pending deep link on ready (#1637)
• trade.schemas: createTradeSchema accepts optional deliveryDays (integer, 1-365) (#1639)
• Removed unused vars that stopped schemas.formatter and feeAccounting.service tests from compiling (TS6133)

How Has This Been Tested?

• Unit tests: stellar.error.handling 19/19, dispute.payout.parity 15/15, deliveryDays cases 6/6
• Mobile jest can't run locally (jest-expo@52 vs expo@57); relying on CI for AppNavigator.test.tsx

Known pre-existing issues (out of scope)

• schemas.formatter.test.ts fixture key GDQLTM4C...FSVN fails the StrKey checksum, so 13 "accept" cases fail
• feeAccounting.service aggregateFees tests time out: the service uses cacheService + $queryRaw, the test mocks findMany
• recordFee still uses float math (#1618 intent lost in 241b228)
• PR #1739 replaced manifest.service.ts, trade.notes.service.ts and frontend useWalletBalance.ts with literal '@' text; not restored here

Related Issues

• Closes #1633
• Closes #1636
• Closes #1637
• Closes #1639

Checklist

• My code follows the repository's coding style guidelines.
• I have performed a self-review of my code.
• My commits follow Conventional Commits formatting.
• No temporary debug code or AI generator disclaimers/signatures were committed.

---

Generated by Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4c42534c-7dd1-40bc-9bbd-5f70602afbd6

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}