fix: declare the package licence and ship MuJoCo's notice - #7
Merged
Conversation
Every push to nuget.org warns "License missing" and the published package carries no licence expression, so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read. EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created on the 10th and missed the sweep; Tracy.NET and Thorvg.NET are in the same position. MIT describes the binding code, which is what the expression is for. The native library is Apache-2.0 and its binaries ship under runtimes/, so the notice now travels with them -- the pattern Tracy.NET and Thorvg.NET already use. Upstream has no NOTICE file, so Apache-2.0 section 4(d) adds nothing further here. The Apache-2.0 boilerplate names no licensor, unlike the MIT and BSD texts the other two repositories ship, so the file opens with a two-line attribution in the style of Tracy-LICENSE.txt. Deliberately without a version number: binding.yml already records the pinned release and binding-fetch-upstream rewrites it, so a number here would go stale in silence. Verified by packing locally and opening the nupkg: the nuspec carries <license type="expression">MIT</license> and THIRD-PARTY-LICENSE-mujoco.txt sits at the package root. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every push to nuget.org warns
License missing, and the published package carries no licence expression — so nuget.org shows nothing where the licence link belongs and a compliance scanner has nothing to read.EvergineTeam/WebGPU.NET#24 fixed this across the eight repositories that existed on 8 August. This one was created on the 10th and missed the sweep; Tracy.NET and Thorvg.NET are in the same position and get their own PRs.
Two changes
The expression.
MITdescribes the binding code, which is whatPackageLicenseExpressionis for, and matches this repository'sLICENSEand the eleven other bindings.The notice. MuJoCo is Apache-2.0 and its binaries ship under
runtimes/, so the licence text now travels with them:This is the pattern
Tracy.NETandThorvg.NETalready use (Tracy-LICENSE.txt,THIRD-PARTY-LICENSE-thorvg.txt); this repository was one of the two shipping natives with no notice at all. Upstream has noNOTICEfile, so Apache-2.0 §4(d) adds nothing further.THIRD-PARTY-LICENSE-mujoco.txtis the verbatim text ofgoogle-deepmind/mujoco@LICENSE, preceded by two lines of attribution in the style ofTracy-LICENSE.txt. That header is needed because the Apache-2.0 boilerplate names no licensor — unlike the MIT and BSD texts the other two ship, a bare copy would not say what it covers. Deliberately without a version number:binding.ymlalready records the pinned release (3.11.0) andbinding-fetch-upstreamrewrites it on upgrades, so a number here would go stale in silence.Verified, not assumed
Packed locally with the .NET 10 SDK and opened the
.nupkg:Byte hygiene checked too — no BOM introduced, LF preserved, tabs preserved. That is the mistake WebGPU.NET#24 had to correct in its own second commit.
Not in scope
JoltPhysics.NETships 72 MB of MIT natives with no notice either, andCesium.NET,Vuforia.NETandRenderDoc.NETare unchecked. A fleet-wide notice audit is separate work.🤖 Generated with Claude Code