Verify both android libraries reach the APK - #17
Merged
Conversation
The README has said it plainly since this morning: android-arm and android-arm64 ship and nothing verifies them. This is the leg that does, ported from Cesium.NET's, where it is green against the real .nupkg. One APK, both ABIs, which is where this differs from Cesium's single-ABI equivalent: the smoke project multi-targets android-arm and android-arm64, so a single build has to put lib/armeabi-v7a/libJoltC.so and lib/arm64-v8a/libJoltC.so in the APK, each over a megabyte, with no other ABI alongside. The build succeeding proves none of that -- a package can carry runtimes/android-*/native and lose them on the way in -- so the leg opens the APK and looks. The activity is not run. No runner can execute an APK without an emulator, and standing one up per release was decided against in Cesium and holds here. The calls in MainActivity exist so the binding assembly is genuinely referenced rather than trimmed, and the README row says the libraries themselves are not executed. Verified locally before pushing, against a package packed from this branch: the APK carries both libraries, 27.0 MB and 23.1 MB uncompressed, and exactly the two expected ABIs.
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README has said it plainly since this morning: "
android-arm,android-arm64: not verified. Nothing installs the package on Android today." This is the leg that closes it, ported from Cesium.NET's, where it is green against the real.nupkg.One APK, both ABIs
Where this differs from Cesium's single-ABI equivalent: the smoke project multi-targets
android-arm;android-arm64, so a single build has to put both libraries in the APK —lib/armeabi-v7a/libJoltC.soandlib/arm64-v8a/libJoltC.sopresent,The build succeeding proves none of that. A package can carry
runtimes/android-*/nativeand lose them on the way into the APK — which is exactly the class of mistake this package shipped for months on wasm and iOS. So the leg opens the APK and looks.Verified locally before pushing
The README row moves from "not verified" to the same wording as Cesium's, keeping the honest part: the libraries themselves are not executed.
One observation out of scope: those
.soare 27 and 23 MB where the wasm archive is 3.7 — they likely carry debug info, the same thing CesiumC's android build stripped from 251 MB to 27. Worth a look in JoltPhysicsC someday; not this PR.