Say what each platform check is actually worth - #16
Merged
Conversation
The list was ten ticks and nothing else, which reads as ten platforms verified equally. They are not, and three of them are not verified at all. Seven are checked against the real .nupkg before publishing: five desktop identifiers and wasm drop a sphere onto a floor through the library, and the iOS simulator is linked and its executable inspected for defined entry points. ios-arm64 is indirect, because a device build needs a signing identity CI does not have. Both android identifiers are not checked at all -- they are ordinary shared libraries and nothing installs the package on Android today. A reader deciding whether to ship on a platform should be able to see which of those they are getting. The android row in particular is a gap worth advertising rather than leaving for somebody to discover.
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list was ten ticks and nothing else, which reads as ten platforms verified equally. They are not, and three of them are not verified at all.
Seven are checked against the real
.nupkgbefore publishing:browser-wasmdrop a sphere onto a floor through the library — it has to fall, settle, and settle on the floor;iossimulator-arm64is linked and its executable inspected for defined entry points (1280Tsymbols, exactly what the generator emits).And two rows say so plainly:
ios-arm64is indirect — a device build needs a signing identity CI does not have, though it links the same archive through the same targets file as the simulator;android-armandandroid-arm64are not checked at all. They are ordinary shared libraries and nothing installs the package on Android today.A reader deciding whether to ship on a platform should be able to see which of those they are getting. The android row in particular is a gap worth advertising rather than leaving for somebody to discover — Cesium.NET has that leg and this repository does not.