Fix the property name the smoke test passes - #11
Merged
Conversation
The workflow passed -p:JoltPhysicsVersion and the project read $(JoltVersion), so the PackageReference got an empty version and all five legs died on NU1015 pointing at the csproj, which is nowhere near the mistake. The project now uses the name the workflow passes, and the step that reads the version off the .nupkg refuses to continue when it comes out empty. The point is where the failure is reported: a restore error naming the project sends you looking at the project, and this one was never there.
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five legs of the new smoke test failed on
NU1015: PackageReference item(s) do not have a version specified.The workflow passes
-p:JoltPhysicsVersion; the project reads$(JoltVersion). My mistake when adapting the workflow from Cesium.NET — a global rename ran before the more specific one and consumed it.Two changes: the project reads the name the workflow passes, and the step that parses the version out of the
.nupkgfilename now fails there if it comes out empty. The second matters more than the first. NU1015 names the csproj, so the error points five jobs away from the actual problem.