fix(ci): fix smoke test MSBuild property name mismatch - #10
Closed
evergine-bindings-automation[bot] wants to merge 1 commit into
Closed
fix(ci): fix smoke test MSBuild property name mismatch#10evergine-bindings-automation[bot] wants to merge 1 commit into
evergine-bindings-automation[bot] wants to merge 1 commit into
Conversation
The smoke job passed -p:JoltPhysicsVersion, but DesktopSmokeTest.csproj reads $(JoltVersion) in its PackageReference. The mismatch left the package reference without a version, and NU1015 failed the build for every runtime identifier the smoke job runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
The
CDworkflow run 31254026271 had everysmoke / <rid>job fail (win-x64,win-arm64,linux-x64,linux-arm64,osx-arm64) at the "Run the package on<rid>" step, with:Why
.github/workflows/package-smoke.ymlinvokeddotnet runwith-p:JoltPhysicsVersion="$JOLT_VERSION", butDesktopSmokeTest/DesktopSmokeTest.csprojreferences the package asVersion="$(JoltVersion)". The property names never matched, so the version resolved to empty and NuGet restore failed for every runtime identifier the smoke job runs. This gated thepublishjob, so nothing published.What this change does
Renames the MSBuild property passed from the workflow from
JoltPhysicsVersiontoJoltVersion, matching the csproj. One line changed, nothing else.Scope note
I did not touch anything under the generator or generated output — this is purely a workflow/CI wiring bug. I also did not investigate whether the smoke test itself (dropping a sphere on a floor) behaves correctly once the version resolves; that should be verified once this PR merges and CD runs again.