fix: declare the binding's licence, not Embree's - #14
Merged
Conversation
The package declared Apache-2.0. That is Embree's licence, not this binding's: the expression describes the code in the package, and the binding code is MIT -- which is what LICENSE in this repository has always said, and what the other eleven bindings declare while shipping third-party natives. Changing it on its own would have made things worse in one respect. That Apache-2.0 was the only mention of the native library's licence anywhere in the nupkg, and Embree's binaries do ship, under runtimes/. So the notice now travels with them, which is the pattern Tracy.NET and Thorvg.NET already use. Upstream has no NOTICE file, so Apache-2.0 section 4(d) adds nothing further here. The Apache-2.0 boilerplate names no licensor, unlike the MIT and BSD texts those two repositories ship, so the file opens with a two-line attribution in the style of Tracy-LICENSE.txt. Deliberately without a version number: binding.yml already records the pinned release (v4.4.1) and binding-fetch-upstream rewrites it, so a number here would go stale in silence. Verified by packing locally and opening the nupkg: the nuspec carries <license type="expression">MIT</license> and THIRD-PARTY-LICENSE-embree.txt sits at the package root. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package declared
Apache-2.0. That is Embree's licence, not this binding's — the expression describes the code in the package, and the binding code is MIT, which is what this repository'sLICENSEhas always said and what the other eleven bindings declare while shipping third-party natives.Why the notice comes with it
Changing that line on its own would have made one thing worse.
Apache-2.0was the only mention of the native library's licence anywhere in the nupkg, and Embree's binaries do ship, underruntimes/. Flipping it to MIT would have left the package silent about what it redistributes.This is the pattern
Tracy.NETandThorvg.NETalready use (Tracy-LICENSE.txt,THIRD-PARTY-LICENSE-thorvg.txt); this repository was one of the two shipping natives with no notice at all. Upstream has noNOTICEfile, so Apache-2.0 §4(d) adds nothing further.THIRD-PARTY-LICENSE-embree.txtis the verbatim text ofRenderKit/embree@LICENSE.txt, preceded by two lines of attribution in the style ofTracy-LICENSE.txt. That header is needed because the Apache-2.0 boilerplate names no licensor — the file is byte-identical to MuJoCo's upstreamLICENSE(same sha256), so a bare copy genuinely would not say which component it covers. Deliberately without a version number:binding.ymlalready records the pinned release (v4.4.1) andbinding-fetch-upstreamrewrites it on upgrades, so a number here would go stale in silence.Verified, not assumed
Packed locally with the .NET 10 SDK and opened the
.nupkg:Byte hygiene checked too — no BOM introduced, LF preserved, tabs preserved. That is the mistake WebGPU.NET#24 had to correct in its own second commit.
Not in scope
JoltPhysics.NETships 72 MB of MIT natives with no notice either, andCesium.NET,Vuforia.NETandRenderDoc.NETare unchecked. A fleet-wide notice audit is separate work.🤖 Generated with Claude Code