Name the toolbox workflow Toolbox Updater - #30
Open
jcant0n wants to merge 1 commit into
Open
Conversation
The dashboard picks out agent runs by exact workflow name:
AGENT_WORKFLOWS = {"CI Doctor", "Binding Updater", "Toolbox Updater"}
agent_runs = [r for r in runs if r["name"] in AGENT_WORKFLOWS]
so "Toolbox update" was never counted here. Nothing failed, the runs simply did
not appear -- the same silent gap the comment next to Vuforia.NET in that file
records. Every other repository in the fleet already uses Toolbox Updater; this
spelling reached Cesium by being copied from Jolt.
Past runs keep the name they were recorded with, so the dashboard picks this up
from the next Monday on, not retroactively.
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line:
name: Toolbox update→name: Toolbox Updater.The fleet dashboard picks out agent runs by exact workflow name:
so this repository's toolbox runs were never counted. Nothing failed and nothing warned — the
runs simply did not appear, which is the same silent gap the comment next to
Vuforia.NETinthat file records.
Every other repository in the fleet already says
Toolbox Updater. Checked all eleven thathave the workflow, along with
CI Doctor,Binding Updater,CI,CDandSync standards:this is the only name that diverges anywhere, and it reached Cesium.NET by being copied from
here.
The workflow is keyed by file path, so its run history survives the rename. But each run
records the name it had at the time, so the dashboard starts counting this repository from the
next Monday on, not retroactively.