Skip to content

A double hyphen in an XML comment made the targets file unloadable #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcant0n merged 1 commit into from
Aug 8, 2026
Merged

A double hyphen in an XML comment made the targets file unloadable #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Evergine.Bindings.CesiumNative/buildTransitive/Evergine.Bindings.CesiumNative.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@

What ForceLoad protects against is real, though: the linker keeps only the members
something references, and a symbol reached solely through a P/Invoke could be dropped. The
package smoke test is what makes this safe to turn off -- it reads the built executable
and fails if cesium_async_system_create is not among its defined symbols.
package smoke test is what makes this safe to turn off rather than hopeful: it reads the
built executable and fails if cesium_async_system_create is not among its defined symbols.

Which runtime identifier to pick is decided by the platform rather than by
$(RuntimeIdentifier), unlike the wasm block above: an iOS build may be for a device or for
Expand Down
Loading