Link an iOS application against the package, and check it took - #20
Merged
Conversation
The last identifier without a leg, and the only one where a green build proves nothing on its own. iOS loads nothing. Apple only allows dynamic libraries that ship inside the app bundle as frameworks, so CesiumC builds a static archive and the package's targets file links it into the executable. Two things have to hold for that, and neither is visible from any other leg: the targets file has to put the archive on the link line, and Native.Dll has to have compiled to "__Internal", because once linked only that name reaches the symbols. Get either wrong and every build still succeeds. So the leg does not stop at building. It opens the .app, checks the executable is over ten megabytes -- cesium-native merged in is tens, and one that linked none of it comes out at a couple -- and then looks for cesium_async_system_create among its defined symbols, which is exactly what would be missing if the name had stayed "CesiumNativeC". The simulator rather than the device, and the limit is stated rather than hidden: a device build needs a signing identity and a provisioning profile a runner does not have. Both identifiers link the same archive through the same targets file, so what this says about ios-arm64 is indirect.
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last identifier without a leg, and the only one where a green build proves nothing on its own.
iOS loads nothing. Apple only allows dynamic libraries that ship inside the app bundle as frameworks, so CesiumC builds a static archive and the package's targets file links it into the executable. Two things have to hold, and neither is visible from any other leg:
Native.Dllhas to have compiled to"__Internal", because once linked only that name reaches the symbols.Get either wrong and every build still succeeds. The failure arrives at the first P/Invoke, in somebody else's application.
So the leg does not stop at building
It opens the
.appand checks two things:cesium_async_system_createis among its defined symbols, which is exactly what would be missing if the name had stayed"CesiumNativeC".The simulator, and the limit is stated rather than hidden
A device build needs a signing identity and a provisioning profile a runner does not have. Both identifiers link the same archive through the same targets file, so what this says about
ios-arm64is indirect.Branched after #16 landed, so this file now carries all five legs: five desktop identifiers, wasm, android and ios.