refactor(test-utilities): generic-type AggregateRootTestCase - #260
Open
maartenpaauw wants to merge 1 commit into
Open
refactor(test-utilities): generic-type AggregateRootTestCase#260maartenpaauw wants to merge 1 commit into
maartenpaauw wants to merge 1 commit into
Conversation
PHPStan couldn't narrow aggregateRootId(), retrieveAggregateRoot(), and persistAggregateRoot() past the AggregateRootId/AggregateRoot interfaces, so subclasses relied on @method docblock overrides and manual @var casts to get concrete types back in their test bodies. Bind AggregateRootIdType and AggregateRootType via @template on the base class so concrete test cases only need to declare @extends AggregateRootTestCase<Id, AggregateRoot> to propagate the narrowed types everywhere, and drop the now-redundant workarounds from the classes that extend it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan couldn't narrow aggregateRootId(), retrieveAggregateRoot(), and persistAggregateRoot() past the AggregateRootId/AggregateRoot interfaces, so subclasses relied on @method docblock overrides and manual @var casts to get concrete types back in their test bodies.
Bind AggregateRootIdType and AggregateRootType via @template on the base class so concrete test cases only need to declare @extends AggregateRootTestCase<Id, AggregateRoot> to propagate the narrowed types everywhere, and drop the now-redundant workarounds from the classes that extend it.