feat: access runs by (proposal, run) identity and render the table from a normalized cache - #253
Merged
Merged
Conversation
CammilleCC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a wrong assumption that DAMNIT runs are only identified by runs. Since commissioning proposals hosts multiple proposals per table, the identifier should now be (proposal, run). While we haven't got bitten by this as the interesting runs seem to differ between proposals, this PR aims to make us bulletproof from that.
Changing the identifier also affects how the data is cached in the frontend. It's now a good opportunity to move most of the server data to Apollo.
We also now remove the proposal into the excluded list but hides it by default:
chrome_3tQKUGZczL.mp4