11 - API (feat): Use Litestart Channels/Subscriptions - #237
Draft
RobertRosca wants to merge 6 commits into
Draft
Conversation
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
from
July 17, 2026 06:20
d397644 to
dda205d
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
3 times, most recently
from
July 17, 2026 09:09
f81a3d7 to
f10fdb8
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
from
July 17, 2026 09:11
f10fdb8 to
ab57cd8
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
2 times, most recently
from
July 17, 2026 09:12
5524190 to
2583f48
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
from
July 17, 2026 10:46
2583f48 to
5da60aa
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
2 times, most recently
from
July 20, 2026 09:25
008305e to
ee4d138
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
from
July 20, 2026 09:28
ee4d138 to
14ed97e
Compare
RobertRosca
force-pushed
the
feat/channels-subscriptions
branch
from
July 20, 2026 09:30
14ed97e to
78b6550
Compare
CammilleCC
reviewed
Jul 20, 2026
CammilleCC
left a comment
CammilleCC
left a comment
Member
There was a problem hiding this comment.
I am a fan of this change
| """Ensure a poll task is running for the proposal.""" | ||
| task = self._tasks.get(proposal_number) | ||
| if task is None or task.done(): | ||
| self._tasks[proposal_number] = asyncio.create_task( |
Member
There was a problem hiding this comment.
When do we close this background task? (e.g., no more subscribed clients).
| # Subscribers consume per-proposal channels; the composition-selected | ||
| # publisher (built in the lifespan) produces the events. The in-memory | ||
| # backend is process-local (ADR-009). | ||
| channels_plugin = ChannelsPlugin( |
Member
There was a problem hiding this comment.
Maybe we should have more boundaries here to be safe. I’ve seen a max_backlog that we can use.
|
|
||
| latest_ts = max(run_timestamps.values(), default=start_at) | ||
|
|
||
| repo.invalidate_metadata_cache() |
Member
There was a problem hiding this comment.
I understand that this is similar to the current behavior, it’s just that this line looks expensive, especially if one reprocesses hundreds of lines at the same time.
Would it be possible to lock or cache the metadata instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬