9 - API (feat): Migrate to Litestar - #235
Draft
RobertRosca wants to merge 12 commits into
Draft
Conversation
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
from
July 17, 2026 06:20
3c2d88f to
a858eeb
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
from
July 17, 2026 06:21
a858eeb to
e499c8b
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
2 times, most recently
from
July 17, 2026 09:09
5504c95 to
5502ad2
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
from
July 17, 2026 09:11
5502ad2 to
537791a
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
2 times, most recently
from
July 17, 2026 09:12
76ad1cb to
0ba7886
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
from
July 17, 2026 10:46
0ba7886 to
e7d0d0d
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
2 times, most recently
from
July 20, 2026 09:26
c2015a9 to
50094a0
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
from
July 20, 2026 09:28
50094a0 to
a6cd987
Compare
RobertRosca
force-pushed
the
feat/migrate-litestar
branch
from
July 20, 2026 09:30
a6cd987 to
500321d
Compare
CammilleCC
reviewed
Jul 20, 2026
CammilleCC
left a comment
CammilleCC
left a comment
Member
There was a problem hiding this comment.
Code movement looks okay in general. And it seems that migrating to Litestar is smooth so far.
| await client.post( | ||
| for token_type_hint, token in tokens: | ||
| try: | ||
| await client.post( # type: ignore[attr-defined] |
Member
There was a problem hiding this comment.
I just realized: can we use client.revoke_token() here instead?
| ) | ||
| try: | ||
| yield | ||
| finally: |
Member
There was a problem hiding this comment.
I was curious about the client.aclose() was done for the OAuth client, but I realized that we don't have that for the MyMDC client as well. While it is not a problem in production, it seems that we recreate clients on the tests. Can you please haave a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬