build: require Inno Setup 6.7.1 and document 14 Windows build failures - #73
Open
Phenitix wants to merge 1 commit into
Open
build: require Inno Setup 6.7.1 and document 14 Windows build failures#73Phenitix wants to merge 1 commit into
Phenitix wants to merge 1 commit into
Conversation
inno/common.iss uses WizardStyle=classic dynamic plus the
Wizard[Small]ImageFileDynamicDark directives, all introduced in Inno Setup 6.3,
and the matching dark-mode assets already ship in desktop-apps. The Chocolatey
pin installed 6.2.2, which rejects them:
Value of [Setup] section directive "WizardStyle" is invalid.
6.7.1 also matches the $issTag pin used a few lines above for the unofficial
language files, whose own comment asks to keep the two in sync.
Adds docs/BUILD-FIXES.md: the full analysis of 14 build failures hit on a
current Windows toolchain (MSVC 14.51 / _MSC_VER 1951, Cygwin without python3,
Python 3.14, Boost 1.92). Thirteen of them need companion changes in core,
desktop-sdk and desktop-apps and are documented there with root cause, patch
and verification.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inno/common.iss uses WizardStyle=classic dynamic plus the Wizard[Small]ImageFileDynamicDark directives, all introduced in Inno Setup 6.3, and the matching dark-mode assets already ship in desktop-apps. The Chocolatey pin installed 6.2.2, which rejects them:
6.7.1 also matches the $issTag pin used a few lines above for the unofficial language files, whose own comment asks to keep the two in sync.
Adds docs/BUILD-FIXES.md: the full analysis of 14 build failures hit on a current Windows toolchain (MSVC 14.51 / _MSC_VER 1951, Cygwin without python3, Python 3.14, Boost 1.92). Thirteen of them need companion changes in core, desktop-sdk and desktop-apps and are documented there with root cause, patch and verification.